Issue 292453010: Update valgrind suppression file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292453010: Update valgrind suppression file (Closed)

Created:
6 years, 7 months ago by egdaniel

Modified:
6 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Update valgrind suppression file BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14791

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/valgrind.supp	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

egdaniel

Update valgrind suppression file so that it handles more cases

6 years, 7 months ago (2014-05-19 20:11:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/292453010/1

6 years, 7 months ago (2014-05-19 21:00:35 UTC) #4

commit-bot: I haz the power

6 years, 7 months ago (2014-05-19 21:06:15 UTC) #6

Message was sent while issue was closed.

Failed to apply patch for tools/valgrind.supp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/valgrind.supp
  Hunk #1 FAILED at 66.
  Hunk #2 FAILED at 77.
  2 out of 2 hunks FAILED -- saving rejects to file tools/valgrind.supp.rej

Patch:       tools/valgrind.supp
Index: tools/valgrind.supp
diff --git a/tools/valgrind.supp b/tools/valgrind.supp
index
30cac399b34e4982e06c6c65d15514313c82994b..2af598d22a08f1a5bac1e83ff7be2b172447f2eb
100644
--- a/tools/valgrind.supp
+++ b/tools/valgrind.supp
@@ -66,6 +66,7 @@
     nv_driver_bug_1
     Memcheck:Param
     write(buf)
+    ...
     obj:/usr/lib/libnvidia-glcore.so*
 }
 {
@@ -77,7 +78,7 @@
     nv_driver_bug_3
     Memcheck:Leak
     fun:calloc
-    obj:/usr/lib/libGL.so*
+    obj:/usr/lib*/libGL.so*
 }
 {
     font_config_bug_1

Expand Messages | Collapse Messages