chrome/browser/ui/website_settings/mock_permission_bubble_request.h - Issue 292453009: Handles iframe permissions requests separately, in a subsequent bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/mock_permission_bubble_request.h

Issue 292453009: Handles iframe permissions requests separately, in a subsequent bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src

Patch Set: fixed duplicate logic Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/website_settings/mock_permission_bubble_request.cc » ('j') | chrome/browser/ui/website_settings/permission_bubble_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/mock_permission_bubble_request.h

diff --git a/chrome/browser/ui/website_settings/mock_permission_bubble_request.h b/chrome/browser/ui/website_settings/mock_permission_bubble_request.h

index a150a93a7f7ab2d352e5d71cec21c4e070381fb2..a40ad5df871f0c6975a65e77c7214bbaa0667e12 100644

--- a/chrome/browser/ui/website_settings/mock_permission_bubble_request.h

+++ b/chrome/browser/ui/website_settings/mock_permission_bubble_request.h

@@ -14,6 +14,8 @@ class MockPermissionBubbleRequest : public PermissionBubbleRequest {

MockPermissionBubbleRequest();

explicit MockPermissionBubbleRequest(const std::string& text);

explicit MockPermissionBubbleRequest(const std::string& text,

+ const GURL& url);

+ explicit MockPermissionBubbleRequest(const std::string& text,

const std::string& accept_label,

const std::string& deny_label);

virtual ~MockPermissionBubbleRequest();

@@ -41,6 +43,7 @@ class MockPermissionBubbleRequest : public PermissionBubbleRequest {

base::string16 text_;

base::string16 accept_label_;

base::string16 deny_label_;

+ GURL hostname_;

};

#endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_MOCK_PERMISSION_BUBBLE_REQUEST_H_