Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 292453006: Chrome proxy telemetry test: better via header checking (Closed)

Created:
6 years, 7 months ago by bolian
Modified:
6 years, 7 months ago
Reviewers:
bengr
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rm_pageset
Visibility:
Public.

Description

Ignore cache hits and invalid responses. Also log bypass during via header checking and restart browser for each page. BUG=374413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271498

Patch Set 1 : . #

Patch Set 2 : check tab None. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M tools/perf/measurements/chrome_proxy.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/metrics/chrome_proxy.py View 1 3 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bolian
Hi Ben, This is a fix to improve current via header validation. Thanks, Bolian
6 years, 7 months ago (2014-05-16 22:16:35 UTC) #1
bengr
On 2014/05/16 22:16:35, bolian wrote: > Hi Ben, > > This is a fix to ...
6 years, 7 months ago (2014-05-17 06:00:52 UTC) #2
bolian
On 2014/05/17 06:00:52, bengr1 wrote: > On 2014/05/16 22:16:35, bolian wrote: > > Hi Ben, ...
6 years, 7 months ago (2014-05-19 16:53:02 UTC) #3
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 7 months ago (2014-05-19 17:09:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/292453006/60001
6 years, 7 months ago (2014-05-19 17:09:59 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 20:42:19 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 21:58:36 UTC) #7
Message was sent while issue was closed.
Change committed as 271498

Powered by Google App Engine
This is Rietveld 408576698