Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2924503002: Add a mixing that handles most of the work for computing completions (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
maxkim, mfairhurst, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a mixing that handles most of the work for computing completions R=maxkim@google.com Committed: https://github.com/dart-lang/sdk/commit/e6c41e9d3d3fe9b1dd27f9796c36e0780cac5204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
A pkg/analyzer_plugin/lib/plugin/completion_mixin.dart View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
I changed a few of the names, but this should be what we discussed in ...
3 years, 6 months ago (2017-06-04 19:34:44 UTC) #2
maxkim
lgtm
3 years, 6 months ago (2017-06-05 17:21:24 UTC) #3
maxkim
lgtm
3 years, 6 months ago (2017-06-05 17:21:26 UTC) #4
Brian Wilkerson
3 years, 6 months ago (2017-06-05 17:25:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6c41e9d3d3fe9b1dd27f9796c36e0780cac5204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698