Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2924473002: Fix simarm build for newer gcc's (Closed)

Created:
3 years, 6 months ago by zra
Modified:
3 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M runtime/platform/globals.h View 2 chunks +9 lines, -1 line 0 comments Download
M runtime/vm/constants_arm.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 6 months ago (2017-06-05 15:43:10 UTC) #2
rmacnak
lgtm
3 years, 6 months ago (2017-06-05 16:14:03 UTC) #3
zra
3 years, 6 months ago (2017-06-05 16:22:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58501225134aa1de4751ba259166b59f2bfb11f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698