Change linux default hidden file save directory to XDG_DATA_HOME

chrome/browser/shell_integration_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/shell_integration_linux.h"
 
 #include <fcntl.h>
 #include <stddef.h>
 
 #include <memory>
@@ skipping 544 matching lines @@
 
   // Just return the name of the executable path for Chrome.
   base::FilePath chrome_exe_path;
   PathService::Get(base::FILE_EXE, &chrome_exe_path);
   return chrome_exe_path;
 }
 
 }  // namespace
 
 base::FilePath GetDataWriteLocation(base::Environment* env) {
-  base::ThreadRestrictions::AssertIOAllowed();

[Lei Zhang, 2017/06/07 06:48:33]

Comment still says "called on the FILE thread" in the header, BTW. Update?

I don't see the code hitting the disk on Linux. Apparently I touched this at one
point:

https://codereview.chromium.org/827013004/diff/20001/chrome/browser/shell_int...

And the previous code had effectively this check, but clearly did not need it.

[Tom Anderson, 2017/06/07 18:38:38]

Done.

-
   return base::nix::GetXDGDirectory(env, "XDG_DATA_HOME", ".local/share");
 }
 
 std::vector<base::FilePath> GetDataSearchLocations(base::Environment* env) {
   base::ThreadRestrictions::AssertIOAllowed();
 
   std::vector<base::FilePath> search_paths;
   base::FilePath write_location = GetDataWriteLocation(env);
   search_paths.push_back(write_location);
 
@@ skipping 526 matching lines @@
   base::FilePath applications_menu = GetDataWriteLocation(env.get());
   applications_menu = applications_menu.AppendASCII("applications");
   std::vector<base::FilePath> shortcut_filenames_app_menu =
       GetExistingProfileShortcutFilenames(profile_path, applications_menu);
   for (const auto& menu : shortcut_filenames_app_menu) {
     DeleteShortcutInApplicationsMenu(menu, base::FilePath(kDirectoryFilename));
   }
 }
 
 }  // namespace shell_integration_linux