Change linux default hidden file save directory to XDG_DATA_HOME

chrome/browser/download/download_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_prefs.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 16 matching lines @@
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/safe_browsing/file_type_policies.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/save_page_type.h"
 
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+#include "chrome/browser/shell_integration_linux.h"
+#endif
+
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/drive/drive_integration_service.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/path_util.h"
 #endif
 
 #if defined(OS_WIN)
 #include "chrome/browser/ui/pdf/adobe_reader_info_win.h"
 #endif
 
@@ skipping 201 matching lines @@
 #if defined(OS_CHROMEOS)
   // If the download path is under /drive, and DriveIntegrationService isn't
   // available (which it isn't for incognito mode, for instance), use the
   // default download directory (/Downloads).
   if (drive::util::IsUnderDriveMountPoint(*download_path_)) {
     drive::DriveIntegrationService* integration_service =
         drive::DriveIntegrationServiceFactory::FindForProfile(profile_);
     if (!integration_service || !integration_service->is_enabled())
       return GetDefaultDownloadDirectoryForProfile();
   }
+#elif defined(OS_LINUX)
+  // TODO(thomasanderson): Remove this when all Linux distros with

[qinmin, 2017/06/07 14:21:18]

This logic would override the |download_path_| set by
DownloadPrefs::SetDownloadPath().
Is this intended? If a test want the download_path_ to be /test/, will that test
fail?

[Tom Anderson, 2017/06/07 18:38:38]

oops.. done.
Hopefully this will fix the test failures

+  // versions of GTK lower than 3.14.7 are no longer supported.  This
+  // should happen when support for Ubuntu Trusty and Debian Jessie
+  // are removed.
+  std::unique_ptr<base::Environment> env(base::Environment::Create());
+  return shell_integration_linux::GetDataWriteLocation(env.get());
 #endif
   return *download_path_;
 }
 
 void DownloadPrefs::SetDownloadPath(const base::FilePath& path) {
   download_path_.SetValue(path);
   SetSaveFilePath(path);
 }
 
 base::FilePath DownloadPrefs::SaveFilePath() const {
@@ skipping 112 matching lines @@
     extensions.erase(extensions.size() - 1);
 
   profile_->GetPrefs()->SetString(prefs::kDownloadExtensionsToOpen, extensions);
 }
 
 bool DownloadPrefs::AutoOpenCompareFunctor::operator()(
     const base::FilePath::StringType& a,
     const base::FilePath::StringType& b) const {
   return base::FilePath::CompareLessIgnoreCase(a, b);
 }