Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: content/browser/screen_orientation/screen_orientation_dispatcher_host_unittest.cc

Issue 292443004: Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill their child processes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/screen_orientation/screen_orientation_dispatcher_host_unittest.cc
===================================================================
--- content/browser/screen_orientation/screen_orientation_dispatcher_host_unittest.cc (revision 271040)
+++ content/browser/screen_orientation/screen_orientation_dispatcher_host_unittest.cc (working copy)
@@ -63,12 +63,9 @@
TEST_F(ScreenOrientationDispatcherHostTest, NullProvider) {
dispatcher_->SetProviderForTests(NULL);
- bool message_was_ok = false;
bool message_was_handled = dispatcher_->OnMessageReceived(
ScreenOrientationHostMsg_Lock(
- blink::WebScreenOrientationLockPortraitPrimary), &message_was_ok);
-
- EXPECT_TRUE(message_was_ok);
+ blink::WebScreenOrientationLockPortraitPrimary));
EXPECT_TRUE(message_was_handled);
}
@@ -92,14 +89,12 @@
int orientationsToTestCount = 7;
for (int i = 0; i < orientationsToTestCount; ++i) {
- bool message_was_ok = false;
bool message_was_handled = false;
blink::WebScreenOrientationLockType orientation = orientationsToTest[i];
message_was_handled = dispatcher_->OnMessageReceived(
- ScreenOrientationHostMsg_Lock(orientation), &message_was_ok);
+ ScreenOrientationHostMsg_Lock(orientation));
- EXPECT_TRUE(message_was_ok);
EXPECT_TRUE(message_was_handled);
EXPECT_EQ(orientation, provider_->orientation());
}
@@ -108,11 +103,9 @@
// Test that when receiving an unlock message, it is correctly dispatched to the
// ScreenOrientationProvider.
TEST_F(ScreenOrientationDispatcherHostTest, ProviderUnlock) {
- bool message_was_ok = false;
bool message_was_handled = dispatcher_->OnMessageReceived(
- ScreenOrientationHostMsg_Unlock(), &message_was_ok);
+ ScreenOrientationHostMsg_Unlock());
- EXPECT_TRUE(message_was_ok);
EXPECT_TRUE(message_was_handled);
EXPECT_TRUE(provider_->unlock_called());
}

Powered by Google App Engine
This is Rietveld 408576698