content/browser/renderer_host/text_input_client_mac_unittest.mm - Issue 292443004: Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill their child processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/text_input_client_mac_unittest.mm

Issue 292443004: Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill their child processes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/socket_stream_dispatcher_host.cc ('k') | content/browser/renderer_host/text_input_client_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/text_input_client_mac_unittest.mm

===================================================================

--- content/browser/renderer_host/text_input_client_mac_unittest.mm (revision 271040)

+++ content/browser/renderer_host/text_input_client_mac_unittest.mm (working copy)

@@ -104,9 +104,8 @@

// Adapter for OnMessageReceived to ignore return type so it can be posted

// to a MessageLoop.

void CallOnMessageReceived(scoped_refptr<TextInputClientMessageFilter> filter,

- const IPC::Message& message,

- bool* message_was_ok) {

- filter->OnMessageReceived(message, message_was_ok);

+ const IPC::Message& message) {

+ filter->OnMessageReceived(message);

}

} // namespace

@@ -153,11 +152,10 @@

scoped_ptr<IPC::Message> message(

new TextInputClientReplyMsg_GotCharacterIndexForPoint(

widget()->GetRoutingID(), kNotFoundValue));

- bool message_ok = true;

// Set |WTF::notFound| to the index |kTaskDelayMs| after the previous

// setting.

PostTask(FROM_HERE,

- base::Bind(&CallOnMessageReceived, filter, *message, &message_ok),

+ base::Bind(&CallOnMessageReceived, filter, *message),

base::TimeDelta::FromMilliseconds(kTaskDelayMs) * 2);

NSUInteger index = service()->GetCharacterIndexAtPoint(