content/browser/renderer_host/p2p/socket_dispatcher_host.cc - Issue 292443004: Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill their child processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_dispatcher_host.cc

Issue 292443004: Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill their child processes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/p2p/socket_dispatcher_host.h ('k') | content/browser/renderer_host/pepper/pepper_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_dispatcher_host.cc

===================================================================

--- content/browser/renderer_host/p2p/socket_dispatcher_host.cc (revision 271040)

+++ content/browser/renderer_host/p2p/socket_dispatcher_host.cc (working copy)

@@ -120,10 +120,9 @@

BrowserThread::DeleteOnIOThread::Destruct(this);

}

-bool P2PSocketDispatcherHost::OnMessageReceived(const IPC::Message& message,

- bool* message_was_ok) {

+bool P2PSocketDispatcherHost::OnMessageReceived(const IPC::Message& message) {

bool handled = true;

- IPC_BEGIN_MESSAGE_MAP_EX(P2PSocketDispatcherHost, message, *message_was_ok)

+ IPC_BEGIN_MESSAGE_MAP(P2PSocketDispatcherHost, message)

IPC_MESSAGE_HANDLER(P2PHostMsg_StartNetworkNotifications,

OnStartNetworkNotifications)

IPC_MESSAGE_HANDLER(P2PHostMsg_StopNetworkNotifications,

@@ -136,7 +135,7 @@

IPC_MESSAGE_HANDLER(P2PHostMsg_SetOption, OnSetOption)

IPC_MESSAGE_HANDLER(P2PHostMsg_DestroySocket, OnDestroySocket)

IPC_MESSAGE_UNHANDLED(handled = false)

- IPC_END_MESSAGE_MAP_EX()

+ IPC_END_MESSAGE_MAP()

return handled;

}