Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Side by Side Diff: content/browser/tracing/trace_message_filter.cc

Issue 292443004: Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill their child processes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/tracing/trace_message_filter.h" 5 #include "content/browser/tracing/trace_message_filter.h"
6 6
7 #include "components/tracing/tracing_messages.h" 7 #include "components/tracing/tracing_messages.h"
8 #include "content/browser/tracing/tracing_controller_impl.h" 8 #include "content/browser/tracing/tracing_controller_impl.h"
9 9
10 namespace content { 10 namespace content {
(...skipping 16 matching lines...) Expand all
27 if (is_awaiting_capture_monitoring_snapshot_ack_) 27 if (is_awaiting_capture_monitoring_snapshot_ack_)
28 OnCaptureMonitoringSnapshotAcked(); 28 OnCaptureMonitoringSnapshotAcked();
29 29
30 if (is_awaiting_buffer_percent_full_ack_) 30 if (is_awaiting_buffer_percent_full_ack_)
31 OnTraceBufferPercentFullReply(0.0f); 31 OnTraceBufferPercentFullReply(0.0f);
32 32
33 TracingControllerImpl::GetInstance()->RemoveTraceMessageFilter(this); 33 TracingControllerImpl::GetInstance()->RemoveTraceMessageFilter(this);
34 } 34 }
35 } 35 }
36 36
37 bool TraceMessageFilter::OnMessageReceived(const IPC::Message& message, 37 bool TraceMessageFilter::OnMessageReceived(const IPC::Message& message) {
38 bool* message_was_ok) {
39 // Always on IO thread (BrowserMessageFilter guarantee). 38 // Always on IO thread (BrowserMessageFilter guarantee).
40 bool handled = true; 39 bool handled = true;
41 IPC_BEGIN_MESSAGE_MAP_EX(TraceMessageFilter, message, *message_was_ok) 40 IPC_BEGIN_MESSAGE_MAP(TraceMessageFilter, message)
42 IPC_MESSAGE_HANDLER(TracingHostMsg_ChildSupportsTracing, 41 IPC_MESSAGE_HANDLER(TracingHostMsg_ChildSupportsTracing,
43 OnChildSupportsTracing) 42 OnChildSupportsTracing)
44 IPC_MESSAGE_HANDLER(TracingHostMsg_EndTracingAck, OnEndTracingAck) 43 IPC_MESSAGE_HANDLER(TracingHostMsg_EndTracingAck, OnEndTracingAck)
45 IPC_MESSAGE_HANDLER(TracingHostMsg_CaptureMonitoringSnapshotAck, 44 IPC_MESSAGE_HANDLER(TracingHostMsg_CaptureMonitoringSnapshotAck,
46 OnCaptureMonitoringSnapshotAcked) 45 OnCaptureMonitoringSnapshotAcked)
47 IPC_MESSAGE_HANDLER(TracingHostMsg_TraceDataCollected, 46 IPC_MESSAGE_HANDLER(TracingHostMsg_TraceDataCollected,
48 OnTraceDataCollected) 47 OnTraceDataCollected)
49 IPC_MESSAGE_HANDLER(TracingHostMsg_MonitoringTraceDataCollected, 48 IPC_MESSAGE_HANDLER(TracingHostMsg_MonitoringTraceDataCollected,
50 OnMonitoringTraceDataCollected) 49 OnMonitoringTraceDataCollected)
51 IPC_MESSAGE_HANDLER(TracingHostMsg_WatchEventMatched, 50 IPC_MESSAGE_HANDLER(TracingHostMsg_WatchEventMatched,
52 OnWatchEventMatched) 51 OnWatchEventMatched)
53 IPC_MESSAGE_HANDLER(TracingHostMsg_TraceBufferPercentFullReply, 52 IPC_MESSAGE_HANDLER(TracingHostMsg_TraceBufferPercentFullReply,
54 OnTraceBufferPercentFullReply) 53 OnTraceBufferPercentFullReply)
55 IPC_MESSAGE_UNHANDLED(handled = false) 54 IPC_MESSAGE_UNHANDLED(handled = false)
56 IPC_END_MESSAGE_MAP_EX() 55 IPC_END_MESSAGE_MAP()
57 return handled; 56 return handled;
58 } 57 }
59 58
60 void TraceMessageFilter::SendBeginTracing( 59 void TraceMessageFilter::SendBeginTracing(
61 const std::string& category_filter_str, 60 const std::string& category_filter_str,
62 base::debug::TraceLog::Options options) { 61 base::debug::TraceLog::Options options) {
63 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 62 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
64 Send(new TracingMsg_BeginTracing(category_filter_str, 63 Send(new TracingMsg_BeginTracing(category_filter_str,
65 base::TimeTicks::NowFromSystemTraceTime(), 64 base::TimeTicks::NowFromSystemTraceTime(),
66 options)); 65 options));
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 if (is_awaiting_buffer_percent_full_ack_) { 161 if (is_awaiting_buffer_percent_full_ack_) {
163 is_awaiting_buffer_percent_full_ack_ = false; 162 is_awaiting_buffer_percent_full_ack_ = false;
164 TracingControllerImpl::GetInstance()->OnTraceBufferPercentFullReply( 163 TracingControllerImpl::GetInstance()->OnTraceBufferPercentFullReply(
165 this, percent_full); 164 this, percent_full);
166 } else { 165 } else {
167 NOTREACHED(); 166 NOTREACHED();
168 } 167 }
169 } 168 }
170 169
171 } // namespace content 170 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/tracing/trace_message_filter.h ('k') | content/browser/vibration/vibration_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698