Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: content/browser/device_sensors/device_orientation_message_filter.cc

Issue 292443004: Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill their child processes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/device_sensors/device_orientation_message_filter.h" 5 #include "content/browser/device_sensors/device_orientation_message_filter.h"
6 6
7 #include "content/browser/device_sensors/device_inertial_sensor_service.h" 7 #include "content/browser/device_sensors/device_inertial_sensor_service.h"
8 #include "content/common/device_sensors/device_orientation_messages.h" 8 #include "content/common/device_sensors/device_orientation_messages.h"
9 9
10 namespace content { 10 namespace content {
11 11
12 DeviceOrientationMessageFilter::DeviceOrientationMessageFilter() 12 DeviceOrientationMessageFilter::DeviceOrientationMessageFilter()
13 : BrowserMessageFilter(DeviceOrientationMsgStart), 13 : BrowserMessageFilter(DeviceOrientationMsgStart),
14 is_started_(false) { 14 is_started_(false) {
15 } 15 }
16 16
17 DeviceOrientationMessageFilter::~DeviceOrientationMessageFilter() { 17 DeviceOrientationMessageFilter::~DeviceOrientationMessageFilter() {
18 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 18 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
19 if (is_started_) 19 if (is_started_)
20 DeviceInertialSensorService::GetInstance()->RemoveConsumer( 20 DeviceInertialSensorService::GetInstance()->RemoveConsumer(
21 CONSUMER_TYPE_ORIENTATION); 21 CONSUMER_TYPE_ORIENTATION);
22 } 22 }
23 23
24 bool DeviceOrientationMessageFilter::OnMessageReceived( 24 bool DeviceOrientationMessageFilter::OnMessageReceived(
25 const IPC::Message& message, 25 const IPC::Message& message) {
26 bool* message_was_ok) {
27 bool handled = true; 26 bool handled = true;
28 IPC_BEGIN_MESSAGE_MAP_EX(DeviceOrientationMessageFilter, 27 IPC_BEGIN_MESSAGE_MAP(DeviceOrientationMessageFilter, message)
29 message,
30 *message_was_ok)
31 IPC_MESSAGE_HANDLER(DeviceOrientationHostMsg_StartPolling, 28 IPC_MESSAGE_HANDLER(DeviceOrientationHostMsg_StartPolling,
32 OnDeviceOrientationStartPolling) 29 OnDeviceOrientationStartPolling)
33 IPC_MESSAGE_HANDLER(DeviceOrientationHostMsg_StopPolling, 30 IPC_MESSAGE_HANDLER(DeviceOrientationHostMsg_StopPolling,
34 OnDeviceOrientationStopPolling) 31 OnDeviceOrientationStopPolling)
35 IPC_MESSAGE_UNHANDLED(handled = false) 32 IPC_MESSAGE_UNHANDLED(handled = false)
36 IPC_END_MESSAGE_MAP_EX() 33 IPC_END_MESSAGE_MAP()
37 return handled; 34 return handled;
38 } 35 }
39 36
40 void DeviceOrientationMessageFilter::OnDeviceOrientationStartPolling() { 37 void DeviceOrientationMessageFilter::OnDeviceOrientationStartPolling() {
41 DCHECK(!is_started_); 38 DCHECK(!is_started_);
42 if (is_started_) 39 if (is_started_)
43 return; 40 return;
44 is_started_ = true; 41 is_started_ = true;
45 DeviceInertialSensorService::GetInstance()->AddConsumer( 42 DeviceInertialSensorService::GetInstance()->AddConsumer(
46 CONSUMER_TYPE_ORIENTATION); 43 CONSUMER_TYPE_ORIENTATION);
(...skipping 11 matching lines...) Expand all
58 55
59 void DeviceOrientationMessageFilter::DidStartDeviceOrientationPolling() { 56 void DeviceOrientationMessageFilter::DidStartDeviceOrientationPolling() {
60 Send(new DeviceOrientationMsg_DidStartPolling( 57 Send(new DeviceOrientationMsg_DidStartPolling(
61 DeviceInertialSensorService::GetInstance()-> 58 DeviceInertialSensorService::GetInstance()->
62 GetSharedMemoryHandleForProcess( 59 GetSharedMemoryHandleForProcess(
63 CONSUMER_TYPE_ORIENTATION, 60 CONSUMER_TYPE_ORIENTATION,
64 PeerHandle()))); 61 PeerHandle())));
65 } 62 }
66 63
67 } // namespace content 64 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698