Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3049)

Unified Diff: chrome/browser/extensions/extension_url_rewrite_browsertest.cc

Issue 2924383003: [MD Bookmarks] Enable by default. (Closed)
Patch Set: more tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_url_rewrite_browsertest.cc
diff --git a/chrome/browser/extensions/extension_url_rewrite_browsertest.cc b/chrome/browser/extensions/extension_url_rewrite_browsertest.cc
index 0e509b49e401395fc1fdd679154a2cbcd095c98c..fa788bdc3fcf784da00e3eb4ea3b24bf7870bad1 100644
--- a/chrome/browser/extensions/extension_url_rewrite_browsertest.cc
+++ b/chrome/browser/extensions/extension_url_rewrite_browsertest.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/location_bar/location_bar.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/testing_profile.h"
@@ -94,6 +95,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionURLRewriteBrowserTest, NewTabPageURLOverride) {
}
IN_PROC_BROWSER_TEST_F(ExtensionURLRewriteBrowserTest, BookmarksURL) {
+ if (MdBookmarksUI::IsEnabled())
+ return;
+
// Navigate to chrome://bookmarks and check that the location bar URL is
// what was entered and the internal URL uses the chrome-extension:// scheme.
const GURL bookmarks_url(chrome::kChromeUIBookmarksURL);
@@ -107,6 +111,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionURLRewriteBrowserTest, BookmarksURL) {
}
IN_PROC_BROWSER_TEST_F(ExtensionURLRewriteBrowserTest, BookmarksURLWithRef) {
+ if (MdBookmarksUI::IsEnabled())
+ return;
+
// Navigate to chrome://bookmarks/#1 and check that the location bar URL is
// what was entered and the internal URL uses the chrome-extension:// scheme.
GURL url_with_ref(chrome::kChromeUIBookmarksURL + std::string("#1"));

Powered by Google App Engine
This is Rietveld 408576698