chrome/test/data/chrome_extension_resource.html - Issue 2924383003: [MD Bookmarks] Enable by default. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(4699)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/test/data/chrome_extension_resource.html

Issue 2924383003: [MD Bookmarks] Enable by default. (Closed)

Patch Set: rebase, address comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/tab_contents/view_source_browsertest.cc ('K') | « chrome/test/BUILD.gn ('k') | chrome/test/data/extensions/override_component_extension/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/chrome_extension_resource.html

diff --git a/chrome/test/data/chrome_extension_resource.html b/chrome/test/data/chrome_extension_resource.html

index 3bc87723c2d24fc268852365900b81d7114340cd..9d84b7e5e58587654bf55776a95660a61bc5fca9 100644

--- a/chrome/test/data/chrome_extension_resource.html

+++ b/chrome/test/data/chrome_extension_resource.html

@@ -2,17 +2,17 @@

<head>

<script>

var xhrStatus = -1;

-var imgUrl = 'chrome-extension://eemcgdkfndhakfknompkggombfjjjeno/images/bookmark_manager_search.png';

+var imgUrl = 'chrome-extension://ombfbiolafbecdcaofoilglhmobpdbnd/icon.png';

alexmos 2017/06/21 18:09:01 nit: maybe add a comment mentioning which extensio

calamity 2017/06/22 04:24:49 Done.

window.onload = function() {

// The call to pushState with chrome-extension:// URL will succeed, since the

// test uses --disable-web-security.

history.pushState('', '',

- 'chrome-extension://eemcgdkfndhakfknompkggombfjjjeno/main.html');

+ 'chrome-extension://ombfbiolafbecdcaofoilglhmobpdbnd/');

var xhr = new XMLHttpRequest();

xhr.onreadystatechange = function() {

if (xhr.readyState == 4) {

- xhrStatus = xhr.status;

+ xhrStatus = xhr.status;

if (xhrStatus == 200) {

document.getElementById('star').src =

window.URL.createObjectURL(this.response);

« chrome/browser/tab_contents/view_source_browsertest.cc ('K') | « chrome/test/BUILD.gn ('k') | chrome/test/data/extensions/override_component_extension/manifest.json » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698