Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: chrome/browser/ui/webui/bookmarks_ui_browsertest.cc

Issue 2924383003: [MD Bookmarks] Enable by default. (Closed)
Patch Set: more tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/test_timeouts.h" 5 #include "base/test/test_timeouts.h"
6 #include "build/build_config.h" 6 #include "build/build_config.h"
7 #include "chrome/browser/ui/browser.h" 7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/chrome_pages.h" 8 #include "chrome/browser/ui/chrome_pages.h"
9 #include "chrome/browser/ui/tabs/tab_strip_model.h" 9 #include "chrome/browser/ui/tabs/tab_strip_model.h"
10 #include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h"
10 #include "chrome/common/url_constants.h" 11 #include "chrome/common/url_constants.h"
11 #include "chrome/test/base/in_process_browser_test.h" 12 #include "chrome/test/base/in_process_browser_test.h"
12 #include "chrome/test/base/ui_test_utils.h" 13 #include "chrome/test/base/ui_test_utils.h"
13 #include "content/public/browser/notification_service.h" 14 #include "content/public/browser/notification_service.h"
14 #include "content/public/browser/web_contents.h" 15 #include "content/public/browser/web_contents.h"
15 #include "content/public/test/browser_test_utils.h" 16 #include "content/public/test/browser_test_utils.h"
16 #include "content/public/test/test_navigation_observer.h" 17 #include "content/public/test/test_navigation_observer.h"
17 18
18 class BookmarksTest : public InProcessBrowserTest { 19 class BookmarksTest : public InProcessBrowserTest {
19 public: 20 public:
(...skipping 28 matching lines...) Expand all
48 ASSERT_EQ("chrome-extension:", out); 49 ASSERT_EQ("chrome-extension:", out);
49 ASSERT_TRUE(content::ExecuteScriptAndExtractString( 50 ASSERT_TRUE(content::ExecuteScriptAndExtractString(
50 tab, 51 tab,
51 "domAutomationController.send(location.pathname)", 52 "domAutomationController.send(location.pathname)",
52 &out)); 53 &out));
53 ASSERT_EQ("/main.html", out); 54 ASSERT_EQ("/main.html", out);
54 } 55 }
55 }; 56 };
56 57
57 IN_PROC_BROWSER_TEST_F(BookmarksTest, ShouldRedirectToExtension) { 58 IN_PROC_BROWSER_TEST_F(BookmarksTest, ShouldRedirectToExtension) {
59 if (MdBookmarksUI::IsEnabled())
tsergeant 2017/06/15 07:23:44 Can these tests remain enabled for MD Bookmarks? T
calamity 2017/06/19 06:00:29 Done. This test in particular has been deleted be
60 return;
61
58 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIBookmarksURL)); 62 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIBookmarksURL));
59 AssertIsBookmarksPage(browser()->tab_strip_model()->GetActiveWebContents()); 63 AssertIsBookmarksPage(browser()->tab_strip_model()->GetActiveWebContents());
60 } 64 }
61 65
62 IN_PROC_BROWSER_TEST_F(BookmarksTest, CommandOpensBookmarksTab) { 66 IN_PROC_BROWSER_TEST_F(BookmarksTest, CommandOpensBookmarksTab) {
67 if (MdBookmarksUI::IsEnabled())
68 return;
69
63 ASSERT_EQ(1, browser()->tab_strip_model()->count()); 70 ASSERT_EQ(1, browser()->tab_strip_model()->count());
64 71
65 // Bring up the bookmarks manager tab. 72 // Bring up the bookmarks manager tab.
66 OpenBookmarksManager(); 73 OpenBookmarksManager();
67 ASSERT_EQ(1, browser()->tab_strip_model()->count()); 74 ASSERT_EQ(1, browser()->tab_strip_model()->count());
68 AssertIsBookmarksPage(browser()->tab_strip_model()->GetActiveWebContents()); 75 AssertIsBookmarksPage(browser()->tab_strip_model()->GetActiveWebContents());
69 } 76 }
70 77
71 // Flaky on Mac: https://crbug.com/524216 78 // Flaky on Mac: https://crbug.com/524216
72 #if defined(OS_MACOSX) || defined(OS_LINUX) 79 #if defined(OS_MACOSX) || defined(OS_LINUX)
73 #define MAYBE_CommandAgainGoesBackToBookmarksTab \ 80 #define MAYBE_CommandAgainGoesBackToBookmarksTab \
74 DISABLED_CommandAgainGoesBackToBookmarksTab 81 DISABLED_CommandAgainGoesBackToBookmarksTab
75 #else 82 #else
76 #define MAYBE_CommandAgainGoesBackToBookmarksTab \ 83 #define MAYBE_CommandAgainGoesBackToBookmarksTab \
77 CommandAgainGoesBackToBookmarksTab 84 CommandAgainGoesBackToBookmarksTab
78 #endif 85 #endif
79 86
80 IN_PROC_BROWSER_TEST_F(BookmarksTest, 87 IN_PROC_BROWSER_TEST_F(BookmarksTest,
81 MAYBE_CommandAgainGoesBackToBookmarksTab) { 88 MAYBE_CommandAgainGoesBackToBookmarksTab) {
89 if (MdBookmarksUI::IsEnabled())
90 return;
91
82 ui_test_utils::NavigateToURL( 92 ui_test_utils::NavigateToURL(
83 browser(), 93 browser(),
84 ui_test_utils::GetTestUrl(base::FilePath(), 94 ui_test_utils::GetTestUrl(base::FilePath(),
85 base::FilePath().AppendASCII("simple.html"))); 95 base::FilePath().AppendASCII("simple.html")));
86 ASSERT_EQ(1, browser()->tab_strip_model()->count()); 96 ASSERT_EQ(1, browser()->tab_strip_model()->count());
87 97
88 // Bring up the bookmarks manager tab. 98 // Bring up the bookmarks manager tab.
89 OpenBookmarksManager(); 99 OpenBookmarksManager();
90 ASSERT_EQ(2, browser()->tab_strip_model()->count()); 100 ASSERT_EQ(2, browser()->tab_strip_model()->count());
91 101
(...skipping 12 matching lines...) Expand all
104 content::TestNavigationObserver navigation_observer( 114 content::TestNavigationObserver navigation_observer(
105 browser()->tab_strip_model()->GetActiveWebContents()); 115 browser()->tab_strip_model()->GetActiveWebContents());
106 chrome::ShowBookmarkManager(browser()); 116 chrome::ShowBookmarkManager(browser());
107 chrome::ShowBookmarkManager(browser()); 117 chrome::ShowBookmarkManager(browser());
108 navigation_observer.Wait(); 118 navigation_observer.Wait();
109 119
110 ASSERT_EQ(1, browser()->tab_strip_model()->count()); 120 ASSERT_EQ(1, browser()->tab_strip_model()->count());
111 } 121 }
112 122
113 IN_PROC_BROWSER_TEST_F(BookmarksTest, BookmarksLoaded) { 123 IN_PROC_BROWSER_TEST_F(BookmarksTest, BookmarksLoaded) {
124 if (MdBookmarksUI::IsEnabled())
125 return;
126
114 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIBookmarksURL)); 127 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIBookmarksURL));
115 ASSERT_EQ(1, browser()->tab_strip_model()->count()); 128 ASSERT_EQ(1, browser()->tab_strip_model()->count());
116 AssertIsBookmarksPage(browser()->tab_strip_model()->GetActiveWebContents()); 129 AssertIsBookmarksPage(browser()->tab_strip_model()->GetActiveWebContents());
117 } 130 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698