Add functionality for copying text within form text fields and form combobox text fields

pdf/pdfium/pdfium_page.cc

Index: pdf/pdfium/pdfium_page.cc
diff --git a/pdf/pdfium/pdfium_page.cc b/pdf/pdfium/pdfium_page.cc
index 7d85d36aa315e5447995c168c4e4a86caf7a9d5d..cc2e8a74cf2c1d1bbc20532e43345985bb2a4768 100644
--- a/pdf/pdfium/pdfium_page.cc
+++ b/pdf/pdfium/pdfium_page.cc
@@ -264,6 +264,11 @@ PDFiumPage::Area PDFiumPage::GetCharIndex(const pp::Point& point,
     DCHECK_NE(control_z_order, link_z_order);
     if (control_z_order > link_z_order) {
       *form_type = control;
+
+      if (*form_type == FPDF_FORMFIELD_TEXTFIELD ||
+          *form_type == FPDF_FORMFIELD_COMBOBOX)

[dsinclair, 2017/06/20 15:21:44]

This and the one below should have {}s as the conditional splits multiple lines.

[drgage, 2017/06/20 23:14:27]

Done - I actually created a helper to convert from a form_type to its
corresponding Area value, so these conditionals aren't here anymore.

+        return PDFiumPage::FORM_TEXT_AREA;
+
       return PDFiumPage::NONSELECTABLE_AREA;
     }
 
@@ -283,6 +288,11 @@ PDFiumPage::Area PDFiumPage::GetCharIndex(const pp::Point& point,
       return area;
   } else if (control > FPDF_FORMFIELD_UNKNOWN) {
     *form_type = control;
+
+    if (*form_type == FPDF_FORMFIELD_TEXTFIELD ||
+        *form_type == FPDF_FORMFIELD_COMBOBOX)
+      return PDFiumPage::FORM_TEXT_AREA;
+
     return PDFiumPage::NONSELECTABLE_AREA;
   }