Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pdf/pdfium/pdfium_engine.h

Issue 2924343005: Add functionality for copying text within form text fields and form combobox text fields (Closed)
Patch Set: Selection bug fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_engine.cc » ('j') | pdf/pdfium/pdfium_engine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdfium/pdfium_engine.h
diff --git a/pdf/pdfium/pdfium_engine.h b/pdf/pdfium/pdfium_engine.h
index 6620c77cb6bad9313550bdb79835ac494e61afdb..eba08407d2f4b5a7f82496088c72b3def5435e91 100644
--- a/pdf/pdfium/pdfium_engine.h
+++ b/pdf/pdfium/pdfium_engine.h
@@ -318,6 +318,11 @@ class PDFiumEngine : public PDFEngine,
const PP_PrintSettings_Dev& print_settings);
void SaveSelectedFormForPrint();
+ // Sets plugin's selected text to be selected text in form text field
+ // if available.
+ void SetFormSelectedText(const FPDF_FORMHANDLE& hHandle,
Lei Zhang 2017/06/16 21:34:53 hHandle -> PDFium variable naming style leaking ou
drgage 2017/06/16 23:15:04 Done.
+ const FPDF_PAGE& page);
+
// Given a mouse event, returns which page and character location it's closest
// to.
PDFiumPage::Area GetCharIndex(const pp::MouseInputEvent& event,
@@ -437,9 +442,13 @@ class PDFiumEngine : public PDFEngine,
// Common code shared by RotateClockwise() and RotateCounterclockwise().
void RotateInternal();
- // Setting selection status of document.
+ // Setting text selection status of document. This does not include text
+ // within form text fields.
void SetSelecting(bool selecting);
+ // Sets status of whether or not focus is in form text field.
+ void SetInFormTextField(bool in_form_text_field);
+
bool PageIndexInBounds(int index) const;
void ScheduleTouchTimer(const pp::TouchInputEvent& event);
@@ -640,12 +649,15 @@ class PDFiumEngine : public PDFEngine,
bool defer_page_unload_;
std::vector<int> deferred_page_unloads_;
- // Used for selection. There could be more than one range if selection spans
- // more than one page.
+ // Used for text selection, but does not include text within form text fields.
+ // There could be more than one range if selection spans more than one page.
std::vector<PDFiumRange> selection_;
- // True if we're in the middle of selection.
+ // True if we're in the middle of text selection.
bool selecting_;
+ // True if focus is on form text field.
+ bool in_form_text_field_;
+
MouseDownState mouse_down_state_;
// Used for searching.
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_engine.cc » ('j') | pdf/pdfium/pdfium_engine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698