Add functionality for copying text within form text fields and form combobox text fields

pdf/pdfium/pdfium_page.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_page.h"
 
 #include <math.h>
 #include <stddef.h>
 
 #include <algorithm>
@@ skipping 245 matching lines @@
       FPDFPage_HasFormFieldAtPoint(engine_->form(), GetPage(), new_x, new_y);
 
   // If there is a control and link at the same point, figure out their z-order
   // to determine which is on top.
   if (link && control > FPDF_FORMFIELD_UNKNOWN) {
     int control_z_order = FPDFPage_FormFieldZOrderAtPoint(
         engine_->form(), GetPage(), new_x, new_y);
     int link_z_order = FPDFLink_GetLinkZOrderAtPoint(GetPage(), new_x, new_y);
     DCHECK_NE(control_z_order, link_z_order);
     if (control_z_order > link_z_order) {
       *form_type = control;

[Lei Zhang, 2017/06/14 07:07:03]

Should we check the form type here as well, and return FORM_TEXT_AREA when
appropriate?

[drgage, 2017/06/14 22:53:40]

Done.

       return PDFiumPage::NONSELECTABLE_AREA;
     }
 
     // We don't handle all possible link types of the PDF. For example,
     // launch actions, cross-document links, etc.
     // In that case, GetLinkTarget() will return NONSELECTABLE_AREA
     // and we should proceed with area detection.
     PDFiumPage::Area area = GetLinkTarget(link, target);
     if (area != PDFiumPage::NONSELECTABLE_AREA)
       return area;
   } else if (link) {
     // We don't handle all possible link types of the PDF. For example,
     // launch actions, cross-document links, etc.
     // See identical block above.
     PDFiumPage::Area area = GetLinkTarget(link, target);
     if (area != PDFiumPage::NONSELECTABLE_AREA)
       return area;
   } else if (control > FPDF_FORMFIELD_UNKNOWN) {
     *form_type = control;
+
+    if (*form_type == FPDF_FORMFIELD_TEXTFIELD) {

[Lei Zhang, 2017/06/14 07:07:03]

We may want to check the combo box type when we get around to improving
selection for that form field type.

[drgage, 2017/06/14 22:53:40]

Done.

+      return PDFiumPage::FORM_TEXT_AREA;
+    }
     return PDFiumPage::NONSELECTABLE_AREA;
   }
 
   if (rv < 0)
     return NONSELECTABLE_AREA;
 
   return GetLink(*char_index, target) != -1 ? WEBLINK_AREA : TEXT_AREA;
 }
 
 base::char16 PDFiumPage::GetCharAtIndex(int index) {
@@ skipping 226 matching lines @@
   page_->loading_count_--;
 }
 
 PDFiumPage::Link::Link() = default;
 
 PDFiumPage::Link::Link(const Link& that) = default;
 
 PDFiumPage::Link::~Link() = default;
 
 }  // namespace chrome_pdf