Add functionality for copying text within form text fields and form combobox text fields

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 1606 matching lines @@
       FPDF_PAGE page = FPDF_LoadPage(doc, i);
       TransformPDFPageForPrinting(page, print_settings);
       FPDF_ClosePage(page);
     }
   }
 }
 
 void PDFiumEngine::SaveSelectedFormForPrint() {
   FORM_ForceToKillFocus(form_);
   client_->FormTextFieldFocusChange(false);
+  SetInFormTextField(false);
+}
+
+void PDFiumEngine::SetFormSelectedText(const FPDF_FORMHANDLE& hHandle,
+                                       const FPDF_PAGE& page) {
+  size_t form_sel_text_len = FORM_GetSelectedText(hHandle, page, nullptr, 0);
+
+  if (form_sel_text_len) {

[Lei Zhang, 2017/06/10 01:55:49]

Invert + early return.

[drgage, 2017/06/12 18:57:47]

Done.

+    base::string16 selected_form_text;

[Lei Zhang, 2017/06/10 01:55:49]

How about calling the std::string version selected_form_text, and this
selected_form_text16?

[drgage, 2017/06/12 18:57:47]

Done.

+    PDFiumAPIStringBufferSizeInBytesAdapter<base::string16> string_adapter(
+        &selected_form_text, form_sel_text_len, false);
+    string_adapter.Close(FORM_GetSelectedText(
+        hHandle, page, string_adapter.GetData(), form_sel_text_len));
+
+    std::string str_selected_form_text = UTF16ToUTF8(selected_form_text);
+    if (str_selected_form_text.c_str() && str_selected_form_text != "") {

[Lei Zhang, 2017/06/10 01:55:49]

I think you just want to check: !str_selected_form_text.empty()

[drgage, 2017/06/12 18:57:47]

Done.

+      pp::PDF::SetSelectedText(GetPluginInstance(),
+                               str_selected_form_text.c_str());
+    }
+  }
 }
 
 void PDFiumEngine::PrintEnd() {
   FORM_DoDocumentAAction(form_, FPDFDOC_AACTION_DP);
 }
 
 PDFiumPage::Area PDFiumEngine::GetCharIndex(const pp::MouseInputEvent& event,
                                             int* page_index,
                                             int* char_index,
                                             int* form_type,
@@ skipping 76 matching lines @@
     return false;
 
   if (page_index != -1) {
     last_page_mouse_down_ = page_index;
     double page_x, page_y;
     pp::Point point = event.GetPosition();
     DeviceToPage(page_index, point.x(), point.y(), &page_x, &page_y);
 
     FORM_OnLButtonDown(form_, pages_[page_index]->GetPage(), 0, page_x, page_y);
     if (form_type > FPDF_FORMFIELD_UNKNOWN) {  // returns -1 sometimes...
-      mouse_down_state_.Set(PDFiumPage::NONSELECTABLE_AREA, target);
+      mouse_down_state_.Set(PDFiumPage::FORM_TEXT_AREA, target);
       bool is_valid_control = (form_type == FPDF_FORMFIELD_TEXTFIELD ||
                                form_type == FPDF_FORMFIELD_COMBOBOX);
 #if defined(PDF_ENABLE_XFA)
       is_valid_control |= (form_type == FPDF_FORMFIELD_XFA);
 #endif
       client_->FormTextFieldFocusChange(is_valid_control);
+      SetInFormTextField(is_valid_control);

[Lei Zhang, 2017/06/10 01:55:49]

Isn't this also going to be true for a combo box?

[drgage, 2017/06/12 18:57:47]

Yeah, you're right. Do you think I should change how is_valid_control is set so
that it's clear which form type it is?

       return true;  // Return now before we get into the selection code.
     }
   }
 
   client_->FormTextFieldFocusChange(false);
+  SetInFormTextField(false);
 
   if (area != PDFiumPage::TEXT_AREA)
     return true;  // Return true so WebKit doesn't do its own highlighting.
 
   if (event.GetClickCount() == 1) {
     OnSingleClick(page_index, char_index);
   } else if (event.GetClickCount() == 2 || event.GetClickCount() == 3) {
     OnMultipleClick(event.GetClickCount(), page_index, char_index);
   }
 
@@ skipping 55 matching lines @@
       bool alt_key = !!(modifiers & PP_INPUTEVENT_MODIFIER_ALTKEY);
       bool ctrl_key = !!(modifiers & PP_INPUTEVENT_MODIFIER_CONTROLKEY);
       bool meta_key = !!(modifiers & PP_INPUTEVENT_MODIFIER_METAKEY);
       bool shift_key = !!(modifiers & PP_INPUTEVENT_MODIFIER_SHIFTKEY);
 
       WindowOpenDisposition disposition = ui::DispositionFromClick(
           middle_button, alt_key, ctrl_key, meta_key, shift_key);
 
       client_->NavigateTo(target.url, disposition);
       client_->FormTextFieldFocusChange(false);
+      SetInFormTextField(false);
       return true;
     }
     if (area == PDFiumPage::DOCLINK_AREA) {
       client_->ScrollToPage(target.page);
       client_->FormTextFieldFocusChange(false);
+      SetInFormTextField(false);
       return true;
     }
   }
 
   // Prevent middle mouse button from selecting texts.
   if (event.GetButton() == PP_INPUTEVENT_MOUSEBUTTON_MIDDLE)
     return false;
 
   if (page_index != -1) {
     double page_x, page_y;
     pp::Point point = event.GetPosition();
     DeviceToPage(page_index, point.x(), point.y(), &page_x, &page_y);
     FORM_OnLButtonUp(form_, pages_[page_index]->GetPage(), 0, page_x, page_y);
   }
 
+  if (area == PDFiumPage::FORM_TEXT_AREA) {
+    SetFormSelectedText(form_, pages_[last_page_mouse_down_]->GetPage());
+  }
+
   if (!selecting_)
     return false;
 
   SetSelecting(false);
   return true;
 }
 
 bool PDFiumEngine::OnMouseMove(const pp::MouseInputEvent& event) {
   int page_index = -1;
   int char_index = -1;
@@ skipping 144 matching lines @@
     OnChar(synthesized);
   }
 
   return rv;
 }
 
 bool PDFiumEngine::OnKeyUp(const pp::KeyboardInputEvent& event) {
   if (last_page_mouse_down_ == -1)
     return false;
 
+  uint32_t modifiers = event.GetModifiers();
+  bool shift_key = !!(modifiers & PP_INPUTEVENT_MODIFIER_SHIFTKEY);
+
+  if (in_form_text_field_ && shift_key) {

[Lei Zhang, 2017/06/10 01:55:49]

If |in_form_text_field_| is false, then it is not necessary to even look up the
keyboard modifier. So this can be written as:

if (in_form_text_field_) {
  uint32_t modifiers = event.GetModifiers();
  if (modifiers & PP_INPUTEVENT_MODIFIER_SHIFTKEY)
    SetFormSelectedText(form_, pages_[last_page_mouse_down_]->GetPage());
}

[drgage, 2017/06/12 18:57:47]

Done.

+    SetFormSelectedText(form_, pages_[last_page_mouse_down_]->GetPage());
+  }
+
   return !!FORM_OnKeyUp(form_, pages_[last_page_mouse_down_]->GetPage(),
                         event.GetKeyCode(), event.GetModifiers());
 }
 
 bool PDFiumEngine::OnChar(const pp::KeyboardInputEvent& event) {
   if (last_page_mouse_down_ == -1)
     return false;
 
   base::string16 str = base::UTF8ToUTF16(event.GetCharacterText().AsString());
   return !!FORM_OnChar(form_, pages_[last_page_mouse_down_]->GetPage(), str[0],
@@ skipping 1541 matching lines @@
   client_->ScrollToPage(most_visible_page);
 }
 
 void PDFiumEngine::SetSelecting(bool selecting) {
   bool was_selecting = selecting_;
   selecting_ = selecting;
   if (selecting_ != was_selecting)
     client_->IsSelectingChanged(selecting);
 }
 
+void PDFiumEngine::SetInFormTextField(bool in_form_text_field) {
+  in_form_text_field_ = in_form_text_field;
+}
+
 void PDFiumEngine::ScheduleTouchTimer(const pp::TouchInputEvent& evt) {
   touch_timers_[++next_touch_timer_id_] = evt;
   client_->ScheduleTouchTimerCallback(next_touch_timer_id_,
                                       kTouchLongPressTimeoutMs);
 }
 
 void PDFiumEngine::KillTouchTimer(int timer_id) {
   touch_timers_.erase(timer_id);
 }
 
@@ skipping 569 matching lines @@
   FPDF_DOCUMENT doc =
       FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, nullptr);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf