Add functionality for copying text within form text fields and form combobox text fields

pdf/pdfium/pdfium_page.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_page.h"
 
 #include <math.h>
 #include <stddef.h>
 
 #include <algorithm>
@@ skipping 246 matching lines @@
 
   // If there is a control and link at the same point, figure out their z-order
   // to determine which is on top.
   if (link && control > FPDF_FORMFIELD_UNKNOWN) {
     int control_z_order = FPDFPage_FormFieldZOrderAtPoint(
         engine_->form(), GetPage(), new_x, new_y);
     int link_z_order = FPDFLink_GetLinkZOrderAtPoint(GetPage(), new_x, new_y);
     DCHECK_NE(control_z_order, link_z_order);
     if (control_z_order > link_z_order) {
       *form_type = control;
-      return PDFiumPage::NONSELECTABLE_AREA;
+      return FormTypeToArea(*form_type);
     }
 
     // We don't handle all possible link types of the PDF. For example,
     // launch actions, cross-document links, etc.
     // In that case, GetLinkTarget() will return NONSELECTABLE_AREA
     // and we should proceed with area detection.
     PDFiumPage::Area area = GetLinkTarget(link, target);
     if (area != PDFiumPage::NONSELECTABLE_AREA)
       return area;
   } else if (link) {
     // We don't handle all possible link types of the PDF. For example,
     // launch actions, cross-document links, etc.
     // See identical block above.
     PDFiumPage::Area area = GetLinkTarget(link, target);
     if (area != PDFiumPage::NONSELECTABLE_AREA)
       return area;
   } else if (control > FPDF_FORMFIELD_UNKNOWN) {
     *form_type = control;
-    return PDFiumPage::NONSELECTABLE_AREA;
+    return FormTypeToArea(*form_type);
   }
 
   if (rv < 0)
     return NONSELECTABLE_AREA;
 
   return GetLink(*char_index, target) != -1 ? WEBLINK_AREA : TEXT_AREA;
 }
 
+PDFiumPage::Area PDFiumPage::FormTypeToArea(int form_type) {

[Lei Zhang, 2017/06/21 00:19:46]

If we make this a static method, we like to make a note of that as follows:

// static
PDFiumPage::Area PDFiumPage::FormTypeToArea(int form_type) {

[drgage, 2017/06/21 01:30:24]

Done.

+  switch (form_type) {
+    case FPDF_FORMFIELD_TEXTFIELD:
+      return PDFiumPage::FORM_TEXT_AREA;

[Lei Zhang, 2017/06/21 00:19:45]

We can omit this return and just let it fall through.

[drgage, 2017/06/21 01:30:24]

Done.

+    case FPDF_FORMFIELD_COMBOBOX:

[Lei Zhang, 2017/06/21 00:19:45]

Let's put this value first, since it appears earlier both by alphabetica order,
and by the form field type value.

[drgage, 2017/06/21 01:30:24]

Done.

+      return PDFiumPage::FORM_TEXT_AREA;
+    default:
+      return PDFiumPage::NONSELECTABLE_AREA;
+  }
+}
+
 base::char16 PDFiumPage::GetCharAtIndex(int index) {
   if (!available_)
     return L'\0';
   return static_cast<base::char16>(FPDFText_GetUnicode(GetTextPage(), index));
 }
 
 int PDFiumPage::GetCharCount() {
   if (!available_)
     return 0;
   return FPDFText_CountChars(GetTextPage());
@@ skipping 217 matching lines @@
   page_->loading_count_--;
 }
 
 PDFiumPage::Link::Link() = default;
 
 PDFiumPage::Link::Link(const Link& that) = default;
 
 PDFiumPage::Link::~Link() = default;
 
 }  // namespace chrome_pdf