Add functionality for copying text within form text fields and form combobox text fields

pdf/pdfium/pdfium_engine.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PDF_PDFIUM_PDFIUM_ENGINE_H_
 #define PDF_PDFIUM_PDFIUM_ENGINE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 300 matching lines @@
   pp::Buffer_Dev PrintPagesAsPDF(const PP_PrintPageNumberRange_Dev* page_ranges,
                                  uint32_t page_range_count,
                                  const PP_PrintSettings_Dev& print_settings);
 
   pp::Buffer_Dev GetFlattenedPrintData(const FPDF_DOCUMENT& doc);
   void FitContentsToPrintableAreaIfRequired(
       const FPDF_DOCUMENT& doc,
       const PP_PrintSettings_Dev& print_settings);
   void SaveSelectedFormForPrint();
 
+  // Sets plugin's selected text to be selected text in form text field

[Lei Zhang, 2017/06/20 00:26:24]

I don't know why I didn't notice earlier. What does it mean for selected text to
be "available" ?

[Lei Zhang, 2017/06/20 18:34:57]

How about this?

Checks if |page| has selected text in a form element. If so, sets that as the
plugin's text selection.

[drgage, 2017/06/20 23:14:27]

Done.

[drgage, 2017/06/20 23:14:27]

What I meant by available is if selected text in a form text field or form
combobox text field exists, then this function will set the plugin's selected
text to be that.

+  // or form combobox text field if available.
+  void SetFormSelectedText(FPDF_FORMHANDLE form_handle, FPDF_PAGE page);
+
   // Given a mouse event, returns which page and character location it's closest
   // to.
   PDFiumPage::Area GetCharIndex(const pp::MouseInputEvent& event,
                                 int* page_index,
                                 int* char_index,
                                 int* form_type,
                                 PDFiumPage::LinkTarget* target);
   PDFiumPage::Area GetCharIndex(const pp::Point& point,
                                 int* page_index,
                                 int* char_index,
@@ skipping 99 matching lines @@
                  pp::ImageData* image_data,
                  void** region,
                  int* stride) const;
 
   // Called when the selection changes.
   void OnSelectionChanged();
 
   // Common code shared by RotateClockwise() and RotateCounterclockwise().
   void RotateInternal();
 
-  // Setting selection status of document.
+  // Setting text selection status of document. This does not include text

[Lei Zhang, 2017/06/20 18:34:58]

Let's use "Sets ..." here for consistency.

[drgage, 2017/06/20 23:14:27]

Done.

+  // within form text fields.
   void SetSelecting(bool selecting);
 
+  // Sets status of whether or not focus is in form text field or form combobox

[Lei Zhang, 2017/06/20 00:26:24]

You can probably omit "status of" here.

[drgage, 2017/06/20 23:14:27]

Done.

+  // text field.
+  void SetInFormTextArea(bool in_form_text_area);
+
   bool PageIndexInBounds(int index) const;
 
   void ScheduleTouchTimer(const pp::TouchInputEvent& event);
   void KillTouchTimer(int timer_id);
   void HandleLongPress(const pp::TouchInputEvent& event);
 
   // FPDF_FORMFILLINFO callbacks.
   static void Form_Invalidate(FPDF_FORMFILLINFO* param,
                               FPDF_PAGE page,
                               double left,
@@ skipping 180 matching lines @@
 
   // The indexes of the pages pending download.
   std::vector<int> pending_pages_;
 
   // During handling of input events we don't want to unload any pages in
   // callbacks to us from PDFium, since the current page can change while PDFium
   // code still has a pointer to it.
   bool defer_page_unload_;
   std::vector<int> deferred_page_unloads_;
 
-  // Used for selection.  There could be more than one range if selection spans
-  // more than one page.
+  // Used for text selection, but does not include text within form text fields.
+  // There could be more than one range if selection spans more than one page.
   std::vector<PDFiumRange> selection_;
-  // True if we're in the middle of selection.
+  // True if we're in the middle of text selection.
   bool selecting_;
 
+  // True if focus is on form text field or form combobox text field.

[Lei Zhang, 2017/06/20 00:26:24]

Line 448 says "focus is in". Be consistent?

[drgage, 2017/06/20 23:14:27]

Done.

+  bool in_form_text_area_;
+
   MouseDownState mouse_down_state_;
 
   // Used for searching.
   std::vector<PDFiumRange> find_results_;
   // Which page to search next.
   int next_page_to_search_;
   // Where to stop searching.
   int last_page_to_search_;
   int last_character_index_to_search_;  // -1 if search until end of page.
   // Which result the user has currently selected.
@@ skipping 139 matching lines @@
   bool GetPDFPageSizeByIndex(const void* pdf_buffer,
                              int pdf_buffer_size,
                              int page_number,
                              double* width,
                              double* height) override;
 };
 
 }  // namespace chrome_pdf
 
 #endif  // PDF_PDFIUM_PDFIUM_ENGINE_H_