Use ClassHierarchy.applyChanges() in MixinFullResolution.

Use ClassHierarchy.applyChanges() in MixinFullResolution.

So, we let the hierarchy to decide how to react to the changes, and
instance of which class hierarchy to create.

This makes initial compilation with Kernel Driver about 5% faster.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5fe793ec4e91200e38cf7a816d7500ce5ddbfd37

[ahe, 2017-06-08 20:18:10]

lgtm

https://codereview.chromium.org/2924333002/diff/1/pkg/kernel/lib/class_hierar...
File pkg/kernel/lib/class_hierarchy.dart (right):

https://codereview.chromium.org/2924333002/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:128: ClassHierarchy
applyChanges(Iterable<Class> changed);
I suggest that you rename this parameter to classes.

Then you can write:

This method is invoked by the client after it changed [classes], ...

https://codereview.chromium.org/2924333002/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:134: final Program program;
Private?

[scheglov, 2017-06-08 21:00:25]

https://codereview.chromium.org/2924333002/diff/1/pkg/kernel/lib/class_hierar...
File pkg/kernel/lib/class_hierarchy.dart (right):

https://codereview.chromium.org/2924333002/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:128: ClassHierarchy
applyChanges(Iterable<Class> changed);
On 2017/06/08 20:18:10, ahe wrote:
> I suggest that you rename this parameter to classes.
> 
> Then you can write:
> 
> This method is invoked by the client after it changed [classes], ...

Done.

https://codereview.chromium.org/2924333002/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:134: final Program program;
On 2017/06/08 20:18:10, ahe wrote:
> Private?

Done.

[scheglov, 2017-06-08 21:00:56]

Description was changed from

==========
Use ClassHierarchy.applyChanges() in MixinFullResolution.

So, we let the hierarchy to decide how to react to the changes, and
instance of which class hierarchy to create.

This makes initial compilation with Kernel Driver about 5% faster.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Use ClassHierarchy.applyChanges() in MixinFullResolution.

So, we let the hierarchy to decide how to react to the changes, and
instance of which class hierarchy to create.

This makes initial compilation with Kernel Driver about 5% faster.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5fe793ec4e91200e38cf7a816d7500ce5ddbfd37
==========

[scheglov, 2017-06-08 21:00:57]

Committed patchset #2 (id:20001) manually as
5fe793ec4e91200e38cf7a816d7500ce5ddbfd37 (presubmit successful).