Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: src/compiler.cc

Issue 292433016: Revert "Reland r21346 "Inobject slack tracking is done on a per-closure basis instead of per-shared… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/builtins.h ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #include "compiler.h" 7 #include "compiler.h"
8 8
9 #include "bootstrapper.h" 9 #include "bootstrapper.h"
10 #include "codegen.h" 10 #include "codegen.h"
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 isolate()->GetHStatistics()->IncrementSubtotals(time_taken_to_create_graph_, 503 isolate()->GetHStatistics()->IncrementSubtotals(time_taken_to_create_graph_,
504 time_taken_to_optimize_, 504 time_taken_to_optimize_,
505 time_taken_to_codegen_); 505 time_taken_to_codegen_);
506 } 506 }
507 } 507 }
508 508
509 509
510 // Sets the expected number of properties based on estimate from compiler. 510 // Sets the expected number of properties based on estimate from compiler.
511 void SetExpectedNofPropertiesFromEstimate(Handle<SharedFunctionInfo> shared, 511 void SetExpectedNofPropertiesFromEstimate(Handle<SharedFunctionInfo> shared,
512 int estimate) { 512 int estimate) {
513 // See the comment in SetExpectedNofProperties.
514 if (shared->live_objects_may_exist()) return;
515
513 // If no properties are added in the constructor, they are more likely 516 // If no properties are added in the constructor, they are more likely
514 // to be added later. 517 // to be added later.
515 if (estimate == 0) estimate = 2; 518 if (estimate == 0) estimate = 2;
516 519
517 // TODO(yangguo): check whether those heuristics are still up-to-date. 520 // TODO(yangguo): check whether those heuristics are still up-to-date.
518 // We do not shrink objects that go into a snapshot (yet), so we adjust 521 // We do not shrink objects that go into a snapshot (yet), so we adjust
519 // the estimate conservatively. 522 // the estimate conservatively.
520 if (shared->GetIsolate()->serializer_enabled()) { 523 if (shared->GetIsolate()->serializer_enabled()) {
521 estimate += 2; 524 estimate += 2;
522 } else if (FLAG_clever_optimizations) { 525 } else if (FLAG_clever_optimizations) {
(...skipping 761 matching lines...) Expand 10 before | Expand all | Expand 10 after
1284 AllowHandleDereference allow_deref; 1287 AllowHandleDereference allow_deref;
1285 bool tracing_on = info()->IsStub() 1288 bool tracing_on = info()->IsStub()
1286 ? FLAG_trace_hydrogen_stubs 1289 ? FLAG_trace_hydrogen_stubs
1287 : (FLAG_trace_hydrogen && 1290 : (FLAG_trace_hydrogen &&
1288 info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter)); 1291 info()->closure()->PassesFilter(FLAG_trace_hydrogen_filter));
1289 return (tracing_on && 1292 return (tracing_on &&
1290 OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL); 1293 OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
1291 } 1294 }
1292 1295
1293 } } // namespace v8::internal 1296 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/builtins.h ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698