Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 292433009: external metrics: change event file location (Closed)

Created:
6 years, 7 months ago by Luigi Semenzato
Modified:
6 years, 7 months ago
CC:
chromium-reviews, jar (doing other things), stevenjb+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, Ilya Sherman, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ratio
Visibility:
Public.

Description

external metrics: change event file location This file used to be in /tmp, but then the security folks decided that /tmp was too dangerous and it got moved to /var/log, but that's the wrong place for it. The corresponding Chrome OS change has just been pushed at https://chromium-review.googlesource.com/#/c/200091/ BUG=chromium:373833 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/external_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Luigi Semenzato
Hi Ricardo, sorry to bother you with this but would you be so kind to ...
6 years, 7 months ago (2014-05-16 17:46:44 UTC) #1
rvargas (doing something else)
Looks good buy my opinion is not worth much. Unfortunately I'm not an owner of ...
6 years, 7 months ago (2014-05-16 19:09:31 UTC) #2
Daniel Erat
lgtm
6 years, 7 months ago (2014-05-17 14:15:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/semenzato@chromium.org/292433009/1
6 years, 7 months ago (2014-05-17 14:16:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 18:19:48 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-18 14:08:47 UTC) #6
Message was sent while issue was closed.
Change committed as 271289

Powered by Google App Engine
This is Rietveld 408576698