Issue 292433002: Move zooming into its own component, imported via HTML Imports.

Issue 292433002: Move zooming into its own component, imported via HTML Imports. (Closed)

Created:
6 years, 7 months ago by jcgregorio

Modified:
6 years, 7 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Move zooming into its own component, imported via HTML Imports. Also, start building our own polyfill library (polyfill.js) using Grunt and Bower. Finally, refactor all the web pages so that the common header and footer material comes from templates. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14783

Patch Set 1 #

Patch Set 2 : grunt #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+506 lines, -392 lines)			Patch
M	experimental/webtry/README.md	View	1 2 3	1 chunk	+2 lines, -1 line	2 comments	Download
A	experimental/webtry/poly/.bowerrc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	experimental/webtry/poly/Gruntfile.js	View	1 2	1 chunk	+64 lines, -0 lines	0 comments	Download
A	experimental/webtry/poly/README.md	View	1 2 3	1 chunk	+18 lines, -0 lines	0 comments	Download
A	experimental/webtry/poly/bower.json	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download
A	experimental/webtry/poly/package.json	View	1 2 3 4	1 chunk	+17 lines, -0 lines	0 comments	Download
M	experimental/webtry/res/css/webtry.css	View		1 chunk	+0 lines, -20 lines	0 comments	Download
A	experimental/webtry/res/imp/zoom.html	View	1 2 3 4	1 chunk	+169 lines, -0 lines	0 comments	Download
D	experimental/webtry/res/js/pointerevents.min.js	View	1 2 3 4 5	1 chunk	+0 lines, -28 lines	0 comments	Download
A	experimental/webtry/res/js/polyfill.js	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	experimental/webtry/res/js/webtry.js	View	1 2	2 chunks	+160 lines, -303 lines	0 comments	Download
M	experimental/webtry/templates/content.html	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
A	experimental/webtry/templates/footercommon.html	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A	experimental/webtry/templates/headercommon.html	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	experimental/webtry/templates/iframe.html	View	1 2	1 chunk	+4 lines, -6 lines	0 comments	Download
M	experimental/webtry/templates/index.html	View	1 2	1 chunk	+5 lines, -7 lines	0 comments	Download
M	experimental/webtry/templates/recent.html	View	1 2 3 4 5 6	1 chunk	+13 lines, -12 lines	0 comments	Download
M	experimental/webtry/templates/workspace.html	View	1 2	2 chunks	+10 lines, -12 lines	0 comments	Download
M	experimental/webtry/webtry.go	View	1 2	4 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm https://codereview.chromium.org/292433002/diff/110001/experimental/webtry/README.md File experimental/webtry/README.md (right): https://codereview.chromium.org/292433002/diff/110001/experimental/webtry/README.md#newcode92 experimental/webtry/README.md:92: * res/js/polyfill.js - Various JS polyfill libraries. To ...

6 years, 7 months ago (2014-05-19 16:27:27 UTC) #2

jcgregorio

https://codereview.chromium.org/292433002/diff/110001/experimental/webtry/README.md File experimental/webtry/README.md (right): https://codereview.chromium.org/292433002/diff/110001/experimental/webtry/README.md#newcode92 experimental/webtry/README.md:92: * res/js/polyfill.js - Various JS polyfill libraries. To rebuild ...

6 years, 7 months ago (2014-05-19 16:33:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/292433002/110001

6 years, 7 months ago (2014-05-19 16:34:13 UTC) #5

Message was sent while issue was closed.

Change committed as 14783

Expand Messages | Collapse Messages