Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2258)

Unified Diff: runtime/bin/BUILD.gn

Issue 2924173005: [fuchsia] Prepare for setting the Dart target architecture appropriately in the host binaries. (Closed)
Patch Set: format Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index 8d56d3f7b34958db96b428548f2f13c5507b1ee8..57090c6721eea6e78f4112737ad0635d1842b3ee 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -749,6 +749,61 @@ dart_executable("dart_bootstrap") {
]
}
+# TODO: Remove when Fuchsia has a checked-in SDK.
zra 2017/06/12 18:12:18 ditto
rmacnak 2017/06/12 21:10:50 Done.
+dart_executable("dart_bootstrap_host_arch") {
zra 2017/06/12 18:12:18 Maybe use a dart_bootstrap() template to avoid dup
rmacnak 2017/06/12 21:10:51 Done.
+ extra_configs = [
+ "..:dart_precompiler_config",
+ "..:dart_no_snapshot_config",
+ "..:dart_use_target_arch_config",
zra 2017/06/12 18:12:18 Target is called _host_arch, but uses a _target_ar
rmacnak 2017/06/12 21:10:50 Yikes, this is backwards and meant to be applied t
+ ]
+ extra_deps = [
+ ":generate_builtin_cc_file",
+ ":generate_io_cc_file",
+ ":generate_io_patch_cc_file",
+ ":generate_html_cc_file",
+ ":generate_html_common_cc_file",
+ ":generate_js_cc_file",
+ ":generate_js_util_cc_file",
+ ":generate_blink_cc_file",
+ ":generate_indexed_db_cc_file",
+ ":generate_cached_patches_cc_file",
+ ":generate_web_gl_cc_file",
+ ":generate_metadata_cc_file",
+ ":generate_web_sql_cc_file",
+ ":generate_svg_cc_file",
+ ":generate_web_audio_cc_file",
+ "..:libdart_nosnapshot_with_precompiler_host_arch",
+ ]
+ extra_defines = [ "NO_OBSERVATORY" ]
+ extra_sources = [
+ "builtin.cc",
+ "builtin.h",
+ "dfe.cc",
+ "dfe.h",
+ "loader.cc",
+ "loader.h",
+ "observatory_assets_empty.cc",
+ "snapshot_empty.cc",
+
+ # Include generated source files.
+ "$target_gen_dir/builtin_gen.cc",
+ "$target_gen_dir/io_gen.cc",
+ "$target_gen_dir/io_patch_gen.cc",
+ "$target_gen_dir/html_gen.cc",
+ "$target_gen_dir/html_common_gen.cc",
+ "$target_gen_dir/js_gen.cc",
+ "$target_gen_dir/js_util_gen.cc",
+ "$target_gen_dir/blink_gen.cc",
+ "$target_gen_dir/indexed_db_gen.cc",
+ "$target_gen_dir/cached_patches_gen.cc",
+ "$target_gen_dir/web_gl_gen.cc",
+ "$target_gen_dir/metadata_gen.cc",
+ "$target_gen_dir/web_sql_gen.cc",
+ "$target_gen_dir/svg_gen.cc",
+ "$target_gen_dir/web_audio_gen.cc",
+ ]
+}
+
if (is_fuchsia) {
hello_fuchsia_source = rebase_path("../tests/vm/dart/hello_fuchsia_test.dart")

Powered by Google App Engine
This is Rietveld 408576698