[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binaries.

[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binaries.

Build another varient of dart_bootstrap targeting the host architecture to ensure reasonable Observatory build times.

Remove assert assuming a root script, which does not exist when gen_snapshot builds core snapshots.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/54e80a8c323e9b7c08054b823e14a52020312917

[rmacnak, 2017-06-12 15:44:45]

Patchset #4 (id:60001) has been deleted

[rmacnak, 2017-06-12 15:46:13]

Description was changed from

==========
[fuchsia] Set the Dart target architecture appropriately in the host binaries.

Build another varient of dart_bootstrap targeting the host architecture to
ensure reasonable Observatory build times.

Remove assert assuming a root script, which does not exist when gen_snapshot
builds core snapshots.
==========

to

==========
[fuchsia] Prepare for setting the Dart target architecture appropriately in the
host binaries.

Build another varient of dart_bootstrap targeting the host architecture to
ensure reasonable Observatory build times.

Remove assert assuming a root script, which does not exist when gen_snapshot
builds core snapshots.
==========

[rmacnak, 2017-06-12 15:47:12]

rmacnak@google.com changed reviewers:
+ zra@google.com

[rmacnak, 2017-06-12 15:49:51]

Description was changed from

==========
[fuchsia] Prepare for setting the Dart target architecture appropriately in the
host binaries.

Build another varient of dart_bootstrap targeting the host architecture to
ensure reasonable Observatory build times.

Remove assert assuming a root script, which does not exist when gen_snapshot
builds core snapshots.
==========

to

==========
[fuchsia] Prepare for setting the Dart target architecture appropriately in the
host binaries.

Build another varient of dart_bootstrap targeting the host architecture to
ensure reasonable Observatory build times.

Remove assert assuming a root script, which does not exist when gen_snapshot
builds core snapshots.
==========

[zra, 2017-06-12 18:12:18]

https://codereview.chromium.org/2924173005/diff/80001/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/2924173005/diff/80001/runtime/BUILD.gn#newcode75
runtime/BUILD.gn:75: # TODO: Fold back into dart_config when Fuchsia has a
checked-in SDK.
Add you or me. Maybe change to "If Fuchsia has a checked-in SDK, this should be
..."

https://codereview.chromium.org/2924173005/diff/80001/runtime/BUILD.gn#newcod...
runtime/BUILD.gn:112: 
What happens if TARGET_ARCH_ isn't set to anything?

https://codereview.chromium.org/2924173005/diff/80001/runtime/BUILD.gn#newcod...
runtime/BUILD.gn:261: # TODO: Remove when Fuchsia has a checked-in SDK.
ditto

https://codereview.chromium.org/2924173005/diff/80001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/2924173005/diff/80001/runtime/bin/BUILD.gn#ne...
runtime/bin/BUILD.gn:752: # TODO: Remove when Fuchsia has a checked-in SDK.
ditto

https://codereview.chromium.org/2924173005/diff/80001/runtime/bin/BUILD.gn#ne...
runtime/bin/BUILD.gn:753: dart_executable("dart_bootstrap_host_arch") {
Maybe use a dart_bootstrap() template to avoid duplication.

https://codereview.chromium.org/2924173005/diff/80001/runtime/bin/BUILD.gn#ne...
runtime/bin/BUILD.gn:757: "..:dart_use_target_arch_config",
Target is called _host_arch, but uses a _target_arch config?

https://codereview.chromium.org/2924173005/diff/80001/runtime/observatory/BUI...
File runtime/observatory/BUILD.gn (right):

https://codereview.chromium.org/2924173005/diff/80001/runtime/observatory/BUI...
runtime/observatory/BUILD.gn:43: pub_build_deps += [
"../bin:dart_bootstrap_host_arch($host_toolchain)" ]
Does the dart_bootstrap use in //utils/generate_patch_sdk.gni also need to be
updated?

If that changes as well, who will be the remaining users of dart_bootstrap?

[rmacnak, 2017-06-12 21:10:51]

https://codereview.chromium.org/2924173005/diff/80001/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/2924173005/diff/80001/runtime/BUILD.gn#newcode75
runtime/BUILD.gn:75: # TODO: Fold back into dart_config when Fuchsia has a
checked-in SDK.
On 2017/06/12 18:12:18, zra wrote:
> Add you or me. Maybe change to "If Fuchsia has a checked-in SDK, this should
be
> ..."

Done.

https://codereview.chromium.org/2924173005/diff/80001/runtime/BUILD.gn#newcod...
runtime/BUILD.gn:112: 
On 2017/06/12 18:12:18, zra wrote:
> What happens if TARGET_ARCH_ isn't set to anything?

We use the architecture the C++ compiler is targeting.

https://codereview.chromium.org/2924173005/diff/80001/runtime/BUILD.gn#newcod...
runtime/BUILD.gn:261: # TODO: Remove when Fuchsia has a checked-in SDK.
On 2017/06/12 18:12:18, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2924173005/diff/80001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/2924173005/diff/80001/runtime/bin/BUILD.gn#ne...
runtime/bin/BUILD.gn:752: # TODO: Remove when Fuchsia has a checked-in SDK.
On 2017/06/12 18:12:18, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2924173005/diff/80001/runtime/bin/BUILD.gn#ne...
runtime/bin/BUILD.gn:753: dart_executable("dart_bootstrap_host_arch") {
On 2017/06/12 18:12:18, zra wrote:
> Maybe use a dart_bootstrap() template to avoid duplication.

Done.

https://codereview.chromium.org/2924173005/diff/80001/runtime/bin/BUILD.gn#ne...
runtime/bin/BUILD.gn:757: "..:dart_use_target_arch_config",
On 2017/06/12 18:12:18, zra wrote:
> Target is called _host_arch, but uses a _target_arch config?

Yikes, this is backwards and meant to be applied to the plain "dart_bootstrap".

https://codereview.chromium.org/2924173005/diff/80001/runtime/observatory/BUI...
File runtime/observatory/BUILD.gn (right):

https://codereview.chromium.org/2924173005/diff/80001/runtime/observatory/BUI...
runtime/observatory/BUILD.gn:43: pub_build_deps += [
"../bin:dart_bootstrap_host_arch($host_toolchain)" ]
On 2017/06/12 18:12:18, zra wrote:
> Does the dart_bootstrap use in //utils/generate_patch_sdk.gni also need to be
> updated?

Done. Also updated the analyzer's summaries to use dart_bootstrap_host_arch
instead of dart.

> If that changes as well, who will be the remaining users of dart_bootstrap?

The standalone AOT tests. The hello_fuchsia AOT build step.

[zra, 2017-06-12 21:19:31]

lgtm

[rmacnak, 2017-06-12 21:33:15]

Description was changed from

==========
[fuchsia] Prepare for setting the Dart target architecture appropriately in the
host binaries.

Build another varient of dart_bootstrap targeting the host architecture to
ensure reasonable Observatory build times.

Remove assert assuming a root script, which does not exist when gen_snapshot
builds core snapshots.
==========

to

==========
[fuchsia] Prepare for setting the Dart target architecture appropriately in the
host binaries.

Build another varient of dart_bootstrap targeting the host architecture to
ensure reasonable Observatory build times.

Remove assert assuming a root script, which does not exist when gen_snapshot
builds core snapshots.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/54e80a8c323e9b7c08054b823e14a52020312917
==========

[rmacnak, 2017-06-12 21:33:17]

Committed patchset #6 (id:120001) manually as
54e80a8c323e9b7c08054b823e14a52020312917 (presubmit successful).