Updated changelog to describe changes made to SecureSocket, SecurityContext, and X509Certificate.

Updated changelog to describe changes made to SecureSocket, SecurityContext, and X509Certificate.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/9cf7ba4f842a126b581eeac0197c269a204ecd78

[bkonyi, 2017-06-07 21:35:06]

bkonyi@google.com changed reviewers:
+ kevmoo@google.com, zra@google.com

[bkonyi, 2017-06-07 21:35:07]

Here's the updated change log associated with this change:
https://codereview.chromium.org/2903743002/. I've done a code search for
SecurityContext.alpnSupported in google3 and didn't find it used, so I'll be
removing that in another CL today.

[zra, 2017-06-07 21:38:20]

lgtm

https://codereview.chromium.org/2924133002/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2924133002/diff/1/CHANGELOG.md#newcode14
CHANGELOG.md:14: * Removed `SecurityContext.alpnSupported` as ALPN is now
supported on all
Let's wait to add this part in the CL that removes alpnSupported.

[bkonyi, 2017-06-07 21:42:56]

Description was changed from

==========
Updated changelog to describe changes made to SecureSocket, SecurityContext, and
X509Certificate.

BUG=
==========

to

==========
Updated changelog to describe changes made to SecureSocket, SecurityContext, and
X509Certificate.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9cf7ba4f842a126b581eeac0197c269a204ecd78
==========

[bkonyi, 2017-06-07 21:42:57]

Committed patchset #2 (id:20001) manually as
9cf7ba4f842a126b581eeac0197c269a204ecd78 (presubmit successful).

[kevmoo, 2017-06-07 23:32:37]

On 2017/06/07 21:38:20, zra wrote:
> lgtm
> 
> https://codereview.chromium.org/2924133002/diff/1/CHANGELOG.md
> File CHANGELOG.md (right):
> 
> https://codereview.chromium.org/2924133002/diff/1/CHANGELOG.md#newcode14
> CHANGELOG.md:14: * Removed `SecurityContext.alpnSupported` as ALPN is now
> supported on all
> Let's wait to add this part in the CL that removes alpnSupported.

We shouldn't just "remove" this method.

We should mark it as deprecated – assuming it always returns true now.

We can remove it in 2.x

[bkonyi, 2017-06-07 23:36:19]

On 2017/06/07 23:32:37, kevmoo wrote:
> On 2017/06/07 21:38:20, zra wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/2924133002/diff/1/CHANGELOG.md
> > File CHANGELOG.md (right):
> > 
> > https://codereview.chromium.org/2924133002/diff/1/CHANGELOG.md#newcode14
> > CHANGELOG.md:14: * Removed `SecurityContext.alpnSupported` as ALPN is now
> > supported on all
> > Let's wait to add this part in the CL that removes alpnSupported.
> 
> We shouldn't just "remove" this method.
> 
> We should mark it as deprecated – assuming it always returns true now.
> 
> We can remove it in 2.x

It doesn't look like this property is actually used in google3 outside of the
dart-sdk or any public repositories that I could find, so I think the risk of
removing it is fairly minimal. If that's not reasonable, I can revert the change
that removed the property.

[zra, 2017-06-08 03:28:08]

On 2017/06/07 23:36:19, bkonyi wrote:
> On 2017/06/07 23:32:37, kevmoo wrote:
> > On 2017/06/07 21:38:20, zra wrote:
> > > lgtm
> > > 
> > > https://codereview.chromium.org/2924133002/diff/1/CHANGELOG.md
> > > File CHANGELOG.md (right):
> > > 
> > > https://codereview.chromium.org/2924133002/diff/1/CHANGELOG.md#newcode14
> > > CHANGELOG.md:14: * Removed `SecurityContext.alpnSupported` as ALPN is now
> > > supported on all
> > > Let's wait to add this part in the CL that removes alpnSupported.
> > 
> > We shouldn't just "remove" this method.
> > 
> > We should mark it as deprecated – assuming it always returns true now.
> > 
> > We can remove it in 2.x
> 
> It doesn't look like this property is actually used in google3 outside of the
> dart-sdk or any public repositories that I could find, so I think the risk of
> removing it is fairly minimal. If that's not reasonable, I can revert the
change
> that removed the property.

Yah, let's revert and deprecate instead. Let's discuss tomorrow.