Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2924093003: (Do not land) Very hacky patch for using -fprofile-functions in the Win-Clang build

Created:
3 years, 6 months ago by hans
Modified:
3 years, 6 months ago
Reviewers:
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

(Do not land) Very hacky patch for using -fprofile-functions in the Win-Clang build BUG=728324

Patch Set 1 #

Patch Set 2 : hacks piled upon hacks, but i think it kinda works #

Patch Set 3 : work #

Patch Set 4 : add 32-bit order files #

Patch Set 5 : rebase etc #

Patch Set 6 : Add code to print functions by call frquency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -23 lines) Patch
M build/config/BUILD.gn View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M build/config/win/BUILD.gn View 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M tools/cygprofile/BUILD.gn View 2 3 4 1 chunk +27 lines, -23 lines 0 comments Download
A tools/cygprofile/cygprofile2.cc View 1 2 3 4 5 1 chunk +138 lines, -0 lines 0 comments Download
A tools/cygprofile/cygprofile2_test.cc View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
hans
I also needed this patch to third_party/swiftshader/src to make the build happy: iff --git a/src/OpenGL/libEGL/BUILD.gn ...
3 years, 6 months ago (2017-06-19 23:39:12 UTC) #2
hans
3 years, 6 months ago (2017-06-19 23:40:25 UTC) #3
More notes:

I ran the browser with
out\release\chrome --renderer-startup-dialog --no-sandbox
to easily get the renderer process id and disable the sandbox to be able to
write out the result file

To upload, I used:
$ upload_to_google_storage.py -b chromium-browser-clang/orderfiles *.orderfile
$ gsutil setacl public-read gs://chromium-browser-clang/orderfiles/*

Powered by Google App Engine
This is Rietveld 408576698