Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2924063002: Add support for implementing getAssists in plugins (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
maxkim, scheglov, mfairhurst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -0 lines) Patch
A pkg/analyzer_plugin/lib/plugin/assist_mixin.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/src/utilities/assist/assist.dart View 1 chunk +46 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/assist/assist.dart View 1 chunk +103 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Analogous to the fix support, but without the problem of needing to pass in errors.
3 years, 6 months ago (2017-06-07 16:05:27 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2924063002/diff/1/pkg/analyzer_plugin/lib/utilities/assist/assist.dart File pkg/analyzer_plugin/lib/utilities/assist/assist.dart (right): https://codereview.chromium.org/2924063002/diff/1/pkg/analyzer_plugin/lib/utilities/assist/assist.dart#newcode34 pkg/analyzer_plugin/lib/utilities/assist/assist.dart:34: void computeFixes(AssistRequest request, AssistCollector collector); computeAssists() ?
3 years, 6 months ago (2017-06-07 16:09:19 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-07 16:19:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
456f790aa70ff07a5148a5945a5712e5f39a1f8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698