Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2924013003: DO NOT SUBMIT, Closure Compiler crash with ES6 class. (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, Tyler Breisacher (Chromium), Dan Beam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT SUBMIT, Closure Compiler crash with ES6 class. Version Closure Compiler (http://github.com/google/closure-compiler) Version: 1.0-SNAPSHOT Built on: 2017-05-31 16:06 Crashes with language_in=ECMASCRIPT_NEXT, language_out=ECMASCRIPT5_STRICT Succeeds with language_in=ECMASCRIPT_NEXT, language_out=ECMASCRIPT_NEXT Run following command to reproduce. ./third_party/closure_compiler/run_compiler search_settings BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -43 lines) Patch
M chrome/browser/resources/settings/search_settings.js View 2 chunks +41 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
dpapad
3 years, 6 months ago (2017-06-07 22:11:18 UTC) #4 
java.lang.RuntimeException: INTERNAL COMPILER ERROR.
Please report this problem.

GETPROP 1107 [length: 13] [source_file: /tmp/tmpKDZ2Cd] is not a string node
  Node(NAME WRAPPER_CSS_CLASS): /tmp/tmpKDZ2Cd:646:6
  var WRAPPER_CSS_CLASS = 'search-highlight-wrapper';
  Parent(VAR): /tmp/tmpKDZ2Cd:646:2
  var WRAPPER_CSS_CLASS = 'search-highlight-wrapper';

	at com.google.javascript.rhino.Node.getString(Node.java:1116)
	at
com.google.javascript.jscomp.Es6SyntacticScopeCreator.scanVars(Es6SyntacticScopeCreator.java:176)
	at
com.google.javascript.jscomp.Es6SyntacticScopeCreator.scanVars(Es6SyntacticScopeCreator.java:222)
	at
com.google.javascript.jscomp.Es6SyntacticScopeCreator.scanRoot(Es6SyntacticScopeCreator.java:121)
	at
com.google.javascript.jscomp.Es6SyntacticScopeCreator.createScope(Es6SyntacticScopeCreator.java:66)
	at com.google.javascript.jscomp.NodeTraversal.getScope(NodeTraversal.java:791)
	at com.google.javascript.jscomp.VarCheck.visit(VarCheck.java:191)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:629)
	at
com.google.javascript.jscomp.NodeTraversal.traverseChildren(NodeTraversal.java:701)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:625)
	at
com.google.javascript.jscomp.NodeTraversal.traverseChildren(NodeTraversal.java:701)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBlockScope(NodeTraversal.java:716)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:623)
	at
com.google.javascript.jscomp.NodeTraversal.traverseFunction(NodeTraversal.java:660)
	at
com.google.javascript.jscomp.NodeTraversal.handleFunction(NodeTraversal.java:591)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:607)
	at
com.google.javascript.jscomp.NodeTraversal.traverseChildren(NodeTraversal.java:701)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:625)
	at
com.google.javascript.jscomp.NodeTraversal.traverseChildren(NodeTraversal.java:701)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:625)
	at
com.google.javascript.jscomp.NodeTraversal.traverseChildren(NodeTraversal.java:701)
	at
com.google.javascript.jscomp.NodeTraversal.handleScript(NodeTraversal.java:579)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:604)
	at
com.google.javascript.jscomp.NodeTraversal.traverseChildren(NodeTraversal.java:701)
	at
com.google.javascript.jscomp.NodeTraversal.traverseBranch(NodeTraversal.java:625)
	at
com.google.javascript.jscomp.NodeTraversal.traverseRoots(NodeTraversal.java:323)
	at com.google.javascript.jscomp.VarCheck.process(VarCheck.java:144)
	at
com.google.javascript.jscomp.PhaseOptimizer$NamedPass.process(PhaseOptimizer.java:298)
	at com.google.javascript.jscomp.PhaseOptimizer.process(PhaseOptimizer.java:232)
	at com.google.javascript.jscomp.Compiler.check(Compiler.java:1098)
	at
com.google.javascript.jscomp.Compiler.performChecksAndTranspilation(Compiler.java:898)
	at com.google.javascript.jscomp.Compiler.access$000(Compiler.java:99)
	at com.google.javascript.jscomp.Compiler$3.call(Compiler.java:832)
	at com.google.javascript.jscomp.Compiler$3.call(Compiler.java:829)
	at
com.google.javascript.jscomp.CompilerExecutor$2.call(CompilerExecutor.java:93)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.UnsupportedOperationException: GETPROP 1107 [length: 13]
[source_file: /tmp/tmpKDZ2Cd] is not a string node
	... 39 more

Powered by Google App Engine
This is Rietveld 408576698