Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 292383004: Add srcset negative x descriptor value tests (Closed)

Created:
6 years, 7 months ago by Yoav Weiss
Modified:
6 years, 6 months ago
Reviewers:
zcorpan, esprehn, eseidel
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add srcset negative x descriptor value tests The implementation handled negative x descriptors properly, but they weren't tested. This CL fixes that. BUG=376726 CC=simonp@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/html/parser/HTMLSrcsetParserTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Yoav Weiss
6 years, 7 months ago (2014-05-23 11:17:13 UTC) #1
zcorpan
LGTM
6 years, 7 months ago (2014-05-23 11:22:15 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 6 months ago (2014-05-28 23:29:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/292383004/1
6 years, 6 months ago (2014-05-28 23:30:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 23:30:25 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-28 23:30:29 UTC) #6
eseidel
lgtm
6 years, 6 months ago (2014-05-28 23:43:20 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-05-29 00:58:00 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 00:58:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/11628)
6 years, 6 months ago (2014-05-29 00:58:27 UTC) #10
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 6 months ago (2014-05-29 04:36:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/292383004/1
6 years, 6 months ago (2014-05-29 04:36:55 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 04:37:36 UTC) #13
Message was sent while issue was closed.
Change committed as 175033

Powered by Google App Engine
This is Rietveld 408576698