Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2923733004: Properly flatten FutureOr types when inferring the type of an async method. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly flatten FutureOr types when inferring the type of an async method. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7ab22d7ad205c65d1ce1c80402ffd4f85b3f524e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -16 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/future_then_conditional.dart.strong.expect View 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_2.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/future_then_conditional_2.dart.strong.expect View 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_3.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/future_then_conditional_3.dart.strong.expect View 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_4.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/future_then_conditional_4.dart.strong.expect View 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_5.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/future_then_conditional_5.dart.strong.expect View 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_6.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/future_then_conditional_6.dart.strong.expect View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-06 19:51:05 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-06 20:01:06 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-06 20:13:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ab22d7ad205c65d1ce1c80402ffd4f85b3f524e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698