Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6357)

Unified Diff: components/signin/ios/browser/account_consistency_service.mm

Issue 2923733003: [signin] Add DICe flow for account consistency requests. (Closed)
Patch Set: Add test for Dice disabled Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/ios/browser/account_consistency_service.mm
diff --git a/components/signin/ios/browser/account_consistency_service.mm b/components/signin/ios/browser/account_consistency_service.mm
index 5f15df39e15e2604550f824dfd693f65c3ab9d2e..8cd3761935331fd98a4308e90b3f30333630b53e 100644
--- a/components/signin/ios/browser/account_consistency_service.mm
+++ b/components/signin/ios/browser/account_consistency_service.mm
@@ -15,6 +15,7 @@
#include "components/pref_registry/pref_registry_syncable.h"
#include "components/prefs/scoped_user_pref_update.h"
#include "components/signin/core/browser/account_reconcilor.h"
+#include "components/signin/core/browser/chrome_connected_header_helper.h"
#include "components/signin/core/browser/signin_client.h"
#include "components/signin/core/browser/signin_header_helper.h"
#include "ios/web/public/browser_state.h"
@@ -331,9 +332,10 @@ void AccountConsistencyService::ApplyCookieRequests() {
double expiration_date = 0;
switch (cookie_requests_.front().request_type) {
case ADD_CHROME_CONNECTED_COOKIE:
- cookie_value = signin::BuildMirrorRequestCookieIfPossible(
- url, signin_manager_->GetAuthenticatedAccountInfo().gaia,
- cookie_settings_.get(), signin::PROFILE_MODE_DEFAULT);
+ cookie_value =
msarda 2017/06/08 23:43:05 Let's avoid this change as explained previously.
+ signin::ChromeConnectedHeaderHelper::BuildRequestCookieIfPossible(
+ url, signin_manager_->GetAuthenticatedAccountInfo().gaia,
+ cookie_settings_.get(), signin::PROFILE_MODE_DEFAULT);
if (cookie_value.empty()) {
// Don't add the cookie. Tentatively correct |last_cookie_update_map_|.
last_cookie_update_map_.erase(cookie_requests_.front().domain);

Powered by Google App Engine
This is Rietveld 408576698