Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: third_party/WebKit/Source/core/paint/LayerClipRecorder.h

Issue 2923683002: Fix nested border radius with composited child. (Closed)
Patch Set: Fix the issue with missing masks Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/LayerClipRecorder.h
diff --git a/third_party/WebKit/Source/core/paint/LayerClipRecorder.h b/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
index 017940eaa1d33a03cbb01fcf782e97688c83070f..ce8eb0cf9fb7e00748f35fcc9ac153e6c736d1e6 100644
--- a/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
+++ b/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
@@ -53,15 +53,24 @@ class CORE_EXPORT LayerClipRecorder {
~LayerClipRecorder();
- private:
- void CollectRoundedRectClips(PaintLayer&,
- const PaintLayer* clip_root,
- GraphicsContext&,
- const LayoutPoint& fragment_offset,
- PaintLayerFlags,
- BorderRadiusClippingRule,
- Vector<FloatRoundedRect>& rounded_rect_clips);
+ // Build a vector of the border radius clips that shoudl be applied to
chrishtr 2017/06/09 22:45:28 nit: should
Stephen Chennney 2017/06/12 14:43:29 Done.
+ // the given PaintLayer, walking up the paint layer tree to the clip_root.
+ // The offset_within_layer is an offset to apply to the clip to position it
+ // in the required clipping coordinates (for cases when the painting
+ // coordinate system is offset from the layer coordinate system).
+ // cross_composited_layers should be true when the search for clips should
+ // continue even if the clipping layer is painting into a different backing.
+ // The BoderRadiusClippingRule defines whether clips on the PaintLayer itself
+ // are included. Output is appended to rounded_rect_clips.
+ static void CollectRoundedRectClips(
+ PaintLayer&,
+ const PaintLayer* clip_root,
+ const LayoutPoint& offset_within_layer,
+ bool cross_composited_layers,
+ BorderRadiusClippingRule,
+ Vector<FloatRoundedRect>& rounded_rect_clips);
+ private:
GraphicsContext& graphics_context_;
const LayoutBoxModelObject& layout_object_;
DisplayItem::Type clip_type_;

Powered by Google App Engine
This is Rietveld 408576698