Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

Issue 2923683002: Fix nested border radius with composited child. (Closed)
Patch Set: Split tests, check layer sizes, document Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
index a9c13519cf420c4563f226f3eac8055206676a44..092929e742f6c29573222644d12a844c7d2c4684 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
@@ -488,15 +488,16 @@ class CORE_EXPORT CompositedLayerMapping final : public GraphicsLayerClient {
const GraphicsLayerPaintInfo&,
const Vector<GraphicsLayerPaintInfo>& layers);
- // Conservatively check that a border-radius clip does not clip a child.
+ // Conservatively check that a sequence of border-radius clips do not clip
+ // this layer. The compositing_ancestor is the nearest compositing ancestor
+ // layer and we can stop checking clips at that layer because higher layer
+ // clips will be applied elsewhere.
// This is a fast approximate test. Depending on the shape of the child and
- // the size of the border radius, this method may return false when in fact
+ // the size of the clips, this method may return false when in fact
// the child is not clipped. We accept the approximation because most border
// radii are small and the outcome is used to reduce the number of layers,
// not influence correctness.
- bool AncestorRoundedCornersWontClip(
- const LayoutBoxModelObject& child,
- const LayoutBoxModelObject& clipping_ancestor);
+ bool AncestorRoundedCornersWontClip(const PaintLayer* compositing_ancestor);
// Return true in |owningLayerIsClipped| iff |m_owningLayer|'s compositing
// ancestor is not a descendant (inclusive) of the clipping container for

Powered by Google App Engine
This is Rietveld 408576698