Issue 292363003: Always call WCO::RenderFrameCreated and WCO::RenderFrameDeleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292363003: Always call WCO::RenderFrameCreated and WCO::RenderFrameDeleted (Closed)

Created:
6 years, 7 months ago by ncarter (slow)

Modified:
6 years, 7 months ago

Reviewers:
jam, nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Always call WCO::RenderFrameCreated and WCO::RenderFrameDeleted. Call WebContentsObserver::RenderFrameCreated for frames created via RenderFrameHostManager::CreateRenderFrame. During WebContentsImpl destruction, make sure that RenderFrameDeleted is always called, by destroying the frame tree and all proxies before clearing the observer list. BUG=364974, 374491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272586

Patch Set 1 #

Patch Set 2 : Formatting fix #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -29 lines)			Patch
M	content/browser/frame_host/render_frame_host_manager.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_manager.cc	View		4 chunks	+10 lines, -0 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_manager_unittest.cc	View		4 chunks	+58 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	2 chunks	+16 lines, -27 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

Hi John -- you reviewed a version of this (as https://codereview.chromium.org/246293009/ ) a few weeks ...

6 years, 7 months ago (2014-05-22 21:16:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/292363003/20001

6 years, 7 months ago (2014-05-23 20:13:35 UTC) #5

Message was sent while issue was closed.

Change committed as 272586

Expand Messages | Collapse Messages