Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2923573002: Move relevance constants for use in plugins (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
maxkim, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +1 line, -18 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/completion/relevance.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
One small piece of what needs to be moved over.
3 years, 6 months ago (2017-06-05 14:47:41 UTC) #2
danrubel
LGTM
3 years, 6 months ago (2017-06-05 15:58:07 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as db7d3d0fe73bd1c84c0040418447c92a6b56c901 (presubmit successful).
3 years, 6 months ago (2017-06-05 17:11:01 UTC) #5
maxkim
lgtm Small preferential nitpick - I'm in favor of ranking in order of relevance value, ...
3 years, 6 months ago (2017-06-05 17:26:58 UTC) #6
Brian Wilkerson
I considered that. I also considered moving the general "high", "default" and "low" values to ...
3 years, 6 months ago (2017-06-05 17:32:20 UTC) #7
maxkim
3 years, 6 months ago (2017-06-05 17:48:03 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698