Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2923563003: Move container policy logic to frame owner classes. (Closed)
Patch Set: Refactor: Move container policy logic to the elements that should define it Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 bool use_fallback = false; 261 bool use_fallback = false;
262 LoadPlugin(url, service_type_, param_names, param_values, use_fallback, 262 LoadPlugin(url, service_type_, param_names, param_values, use_fallback,
263 false); 263 false);
264 } 264 }
265 265
266 bool HTMLPlugInElement::ShouldAccelerate() const { 266 bool HTMLPlugInElement::ShouldAccelerate() const {
267 PluginView* plugin = OwnedPlugin(); 267 PluginView* plugin = OwnedPlugin();
268 return plugin && plugin->PlatformLayer(); 268 return plugin && plugin->PlatformLayer();
269 } 269 }
270 270
271 Vector<WebParsedFeaturePolicyDeclaration>
272 HTMLPlugInElement::ConstructContainerPolicy() const {
273 Vector<WebParsedFeaturePolicyDeclaration> container_policy;
raymes 2017/06/12 22:54:26 nit: perhaps add a comment about why we return an
iclelland 2017/06/13 14:38:33 Done, though I actually duplicated the <frame> log
274 return container_policy;
275 }
276
271 void HTMLPlugInElement::DetachLayoutTree(const AttachContext& context) { 277 void HTMLPlugInElement::DetachLayoutTree(const AttachContext& context) {
272 // Update the FrameViewBase the next time we attach (detaching destroys the 278 // Update the FrameViewBase the next time we attach (detaching destroys the
273 // plugin). 279 // plugin).
274 // FIXME: None of this "needsPluginUpdate" related code looks right. 280 // FIXME: None of this "needsPluginUpdate" related code looks right.
275 if (GetLayoutObject() && !UseFallbackContent()) 281 if (GetLayoutObject() && !UseFallbackContent())
276 SetNeedsPluginUpdate(true); 282 SetNeedsPluginUpdate(true);
277 283
278 if (is_delaying_load_event_) { 284 if (is_delaying_load_event_) {
279 is_delaying_load_event_ = false; 285 is_delaying_load_event_ = false;
280 GetDocument().DecrementLoadEventDelayCount(); 286 GetDocument().DecrementLoadEventDelayCount();
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 679
674 void HTMLPlugInElement::LazyReattachIfNeeded() { 680 void HTMLPlugInElement::LazyReattachIfNeeded() {
675 if (!UseFallbackContent() && NeedsPluginUpdate() && GetLayoutObject() && 681 if (!UseFallbackContent() && NeedsPluginUpdate() && GetLayoutObject() &&
676 !IsImageType()) { 682 !IsImageType()) {
677 LazyReattachIfAttached(); 683 LazyReattachIfAttached();
678 SetPersistedPlugin(nullptr); 684 SetPersistedPlugin(nullptr);
679 } 685 }
680 } 686 }
681 687
682 } // namespace blink 688 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698