Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameElement.cpp

Issue 2923563003: Move container policy logic to frame owner classes. (Closed)
Patch Set: Refactor: Move container policy logic to the elements that should define it Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann (hausmann@kde.org) 4 * (C) 2000 Simon Hausmann (hausmann@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 frame_border_set_ = !params.new_value.IsNull(); 69 frame_border_set_ = !params.new_value.IsNull();
70 // FIXME: If we are already attached, this has no effect. 70 // FIXME: If we are already attached, this has no effect.
71 } else if (params.name == noresizeAttr) { 71 } else if (params.name == noresizeAttr) {
72 if (GetLayoutObject()) 72 if (GetLayoutObject())
73 GetLayoutObject()->UpdateFromElement(); 73 GetLayoutObject()->UpdateFromElement();
74 } else { 74 } else {
75 HTMLFrameElementBase::ParseAttribute(params); 75 HTMLFrameElementBase::ParseAttribute(params);
76 } 76 }
77 } 77 }
78 78
79 Vector<WebParsedFeaturePolicyDeclaration>
80 HTMLFrameElement::ConstructContainerPolicy() const {
81 // Frame elements are not allowed to enable the fullscreen feature. Add an
raymes 2017/06/12 22:54:26 tiny nit: a link to spec or documentation here mig
iclelland 2017/06/13 14:38:33 Done.
82 // empty whitelist for the fullscreen feature so that the framed content is
83 // unable to use the API, regardless of origin.
84 Vector<WebParsedFeaturePolicyDeclaration> container_policy;
85 WebParsedFeaturePolicyDeclaration whitelist;
86 whitelist.feature = WebFeaturePolicyFeature::kFullscreen;
87 whitelist.matches_all_origins = false;
88 whitelist.origins = Vector<WebSecurityOrigin>(0UL);
89 container_policy.push_back(whitelist);
90 return container_policy;
91 }
92
79 } // namespace blink 93 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698