Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: mojo/tools/test_runner.py

Issue 292353003: Mojo: Make mojob.sh not skip some tests (due to cached test results). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add mojo_public_bindings_unittests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/tools/data/unittests ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/test_runner.py
diff --git a/mojo/tools/test_runner.py b/mojo/tools/test_runner.py
index c36caeab761f412cca38ed0a2356d312b78ea769..18a4fb5917ade88caa4d4092a963e54ea9bcce1f 100755
--- a/mojo/tools/test_runner.py
+++ b/mojo/tools/test_runner.py
@@ -67,7 +67,14 @@ def main(argv):
successes_cache_file = open(successes_cache_filename, 'ab') \
if successes_cache_filename else None
for gtest in gtest_list:
- if successes_cache_file:
+ if gtest[0] == '*':
+ gtest = gtest[1:]
+ _logging.debug("%s is marked as non-cacheable" % gtest)
+ cacheable = False
+ else:
+ cacheable = True
+
+ if successes_cache_file and cacheable:
_logging.debug("Getting transitive hash for %s ... " % gtest)
try:
gtest_hash = transitive_hash(gtest)
@@ -80,17 +87,17 @@ def main(argv):
print "Skipping %s (previously succeeded)" % gtest
continue
- print "Running %s ..." % gtest
+ print "Running %s...." % gtest,
try:
subprocess.check_output(["./" + gtest], stderr=subprocess.STDOUT)
- print " Succeeded"
+ print "Succeeded"
# Record success.
- if successes_cache_filename:
+ if successes_cache_filename and cacheable:
successes.add(gtest_hash)
successes_cache_file.write(gtest_hash + '\n')
successes_cache_file.flush()
except subprocess.CalledProcessError as e:
- print " Failed with exit code %d and output:" % e.returncode
+ print "Failed with exit code %d and output:" % e.returncode
print 72 * '-'
print e.output
print 72 * '-'
« no previous file with comments | « mojo/tools/data/unittests ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698