Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 292353003: Mojo: Make mojob.sh not skip some tests (due to cached test results). (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Make mojob.sh not skip some tests (due to cached test results). R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272369

Patch Set 1 #

Patch Set 2 : add mojo_public_bindings_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M mojo/tools/data/unittests View 1 1 chunk +7 lines, -3 lines 0 comments Download
M mojo/tools/test_runner.py View 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-22 21:00:14 UTC) #1
darin (slow to review)
LGTM mojo_public_bindings_unittests also have data dependencies for the validation tests.
6 years, 7 months ago (2014-05-22 23:31:51 UTC) #2
viettrungluu
6 years, 7 months ago (2014-05-22 23:55:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r272369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698