Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: components/browser_watcher/stability_report_extractor.h

Issue 2923523002: Decouple stability instrumentation recording and collection (Closed)
Patch Set: PostmortemDeleter unittest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/stability_report_extractor.h
diff --git a/components/browser_watcher/stability_report_extractor.h b/components/browser_watcher/stability_report_extractor.h
index 5ff90339e34013b2b072b30203224d88c1eb194c..80491464086f76f9a7bca824ddee4476936bb07d 100644
--- a/components/browser_watcher/stability_report_extractor.h
+++ b/components/browser_watcher/stability_report_extractor.h
@@ -12,7 +12,7 @@
namespace browser_watcher {
-// DO NOT CHANGE VALUES. This is logged persistently in a histogram.
+// DO NOT REMOVE OR REORDER VALUES. This is logged persistently in a histogram.
enum CollectionStatus {
NONE = 0,
SUCCESS = 1, // Successfully registered a report with Crashpad.
@@ -22,7 +22,11 @@ enum CollectionStatus {
WRITE_TO_MINIDUMP_FAILED = 5,
DEBUG_FILE_DELETION_FAILED = 6,
FINISHED_WRITING_CRASH_REPORT_FAILED = 7,
- COLLECTION_STATUS_MAX = 8
+ UNCLEAN_SHUTDOWN = 8,
+ UNCLEAN_SESSION = 9,
+ COLLECTION_ATTEMPT = 10,
+ // New values go here.
+ COLLECTION_STATUS_MAX = 11
};
// Extracts a stability report from a stability file.

Powered by Google App Engine
This is Rietveld 408576698