Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2923493003: Make ComputedStyleBase internal pointer setters move-only. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/storage_only.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index dc0ba2a0dfe4adb5238a7d0e7202135110ccb349..b51c36dc9a21548e9cba1c1c16be6491c78a74de 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -922,7 +922,7 @@ void ComputedStyle::SetCursorList(CursorList* other) {
}
void ComputedStyle::SetQuotes(RefPtr<QuotesData> q) {
- SetQuotesInternal(q);
+ SetQuotesInternal(std::move(q));
}
bool ComputedStyle::QuotesDataEquivalent(const ComputedStyle& other) const {
@@ -1207,7 +1207,7 @@ void ComputedStyle::ApplyMotionPathTransform(
}
void ComputedStyle::SetTextShadow(RefPtr<ShadowList> s) {
- SetTextShadowInternal(s);
+ SetTextShadowInternal(std::move(s));
}
bool ComputedStyle::TextShadowDataEquivalent(const ComputedStyle& other) const {
@@ -1877,8 +1877,8 @@ void ComputedStyle::RestoreParentTextDecorations(
SetHasSimpleUnderlineInternal(parent_style.HasSimpleUnderlineInternal());
if (AppliedTextDecorationsInternal() !=
parent_style.AppliedTextDecorationsInternal()) {
- SetAppliedTextDecorationsInternal(
- parent_style.AppliedTextDecorationsInternal());
+ SetAppliedTextDecorationsInternal(RefPtr<AppliedTextDecorationList>(
+ parent_style.AppliedTextDecorationsInternal()));
}
}
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/storage_only.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698