third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp - Issue 2923433002: Move ExecuteScript method from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2923433002: Move ExecuteScript method from WebFrame to WebLocalFrame. (Closed)

Patch Set: Tweaked a comment in WebViewPlugin::WebViewHelper::main_frame [as suggested in CR feedback] Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

index a72b4e1fa0eb23f7fdd7fd098622f3a40d497e1c..9ba29f065ff49b5c48a78a9256a1b74af84abe81 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

@@ -147,10 +147,6 @@ void WebRemoteFrameImpl::DispatchUnloadEvent() {

NOTREACHED();

}

-void WebRemoteFrameImpl::ExecuteScript(const WebScriptSource&) {

- NOTREACHED();

void WebRemoteFrameImpl::ExecuteScriptInIsolatedWorld(

int world_id,

const WebScriptSource* sources,