Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc

Issue 2923393002: Make UI with PermissionRequestManager enabled match PermissionQueueController (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
diff --git a/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc b/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
index c4ecd24dd1a80b00e0b6e22188d4385a4a201a4d..a37ce1c53a0d1c17f21c058be7b840425c189733 100644
--- a/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
+++ b/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
@@ -42,20 +42,12 @@ ContentSettingsType GroupedPermissionInfoBarDelegate::GetContentSettingType(
return permission_prompt_->GetContentSettingType(position);
}
-int GroupedPermissionInfoBarDelegate::GetIconIdForPermission(
- size_t position) const {
- return permission_prompt_->GetIconIdForPermission(position);
-}
-
-base::string16 GroupedPermissionInfoBarDelegate::GetMessageTextFragment(
- size_t position) const {
- return permission_prompt_->GetMessageTextFragment(position);
+int GroupedPermissionInfoBarDelegate::GetIconId() const {
+ return permission_prompt_->GetIconId();
}
base::string16 GroupedPermissionInfoBarDelegate::GetMessageText() const {
- return l10n_util::GetStringFUTF16(
- IDS_PERMISSIONS_BUBBLE_PROMPT,
- url_formatter::FormatUrlForSecurityDisplay(requesting_origin_));
+ return permission_prompt_->GetMessageText();
}
bool GroupedPermissionInfoBarDelegate::Accept() {
@@ -105,20 +97,11 @@ GroupedPermissionInfoBarDelegate::GetInfoBarType() const {
}
int GroupedPermissionInfoBarDelegate::GetButtons() const {
- // If there is only one permission in the infobar, we show both OK and CANCEL
- // button to allow/deny it. If there are multiple, we only show OK button
- // which means making decision for all permissions according to each accept
- // toggle.
- return (PermissionCount() > 1) ? BUTTON_OK : (BUTTON_OK | BUTTON_CANCEL);
+ return BUTTON_OK | BUTTON_CANCEL;
}
base::string16 GroupedPermissionInfoBarDelegate::GetButtonLabel(
InfoBarButton button) const {
- if (PermissionCount() > 1) {
- return l10n_util::GetStringUTF16((button == BUTTON_OK) ? IDS_APP_OK
- : IDS_APP_CANCEL);
- }
-
return l10n_util::GetStringUTF16((button == BUTTON_OK) ? IDS_PERMISSION_ALLOW
: IDS_PERMISSION_DENY);
}

Powered by Google App Engine
This is Rietveld 408576698