Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: chrome/browser/permissions/permission_dialog_delegate.cc

Issue 2923393002: Make UI with PermissionRequestManager enabled match PermissionQueueController (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_dialog_delegate.h" 5 #include "chrome/browser/permissions/permission_dialog_delegate.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 // TODO(timloh): Handle grouped media permissions (camera + microphone). 151 // TODO(timloh): Handle grouped media permissions (camera + microphone).
152 DCHECK_EQ(1u, permission_prompt_->PermissionCount()); 152 DCHECK_EQ(1u, permission_prompt_->PermissionCount());
153 153
154 std::vector<int> content_settings_types{ 154 std::vector<int> content_settings_types{
155 permission_prompt_->GetContentSettingType(0)}; 155 permission_prompt_->GetContentSettingType(0)};
156 156
157 j_delegate_.Reset(Java_PermissionDialogDelegate_create( 157 j_delegate_.Reset(Java_PermissionDialogDelegate_create(
158 env, reinterpret_cast<uintptr_t>(this), tab_->GetJavaObject(), 158 env, reinterpret_cast<uintptr_t>(this), tab_->GetJavaObject(),
159 base::android::ToJavaIntArray(env, content_settings_types).obj(), 159 base::android::ToJavaIntArray(env, content_settings_types).obj(),
160 ResourceMapper::MapFromChromiumId( 160 ResourceMapper::MapFromChromiumId(permission_prompt_->GetIconId()),
161 permission_prompt_->GetIconIdForPermission(0)), 161 ConvertUTF16ToJavaString(env, permission_prompt_->GetMessageText()),
162 ConvertUTF16ToJavaString(env, permission_prompt_->GetMessageText(0)),
163 ConvertUTF16ToJavaString(env, permission_prompt_->GetLinkText()), 162 ConvertUTF16ToJavaString(env, permission_prompt_->GetLinkText()),
164 primaryButtonText, secondaryButtonText, 163 primaryButtonText, secondaryButtonText,
165 permission_prompt_->ShouldShowPersistenceToggle())); 164 permission_prompt_->ShouldShowPersistenceToggle()));
166 } 165 }
167 166
168 void PermissionDialogDelegate::Accept(JNIEnv* env, 167 void PermissionDialogDelegate::Accept(JNIEnv* env,
169 const JavaParamRef<jobject>& obj, 168 const JavaParamRef<jobject>& obj,
170 jboolean persist) { 169 jboolean persist) {
171 if (infobar_delegate_) { 170 if (infobar_delegate_) {
172 if (infobar_delegate_->ShouldShowPersistenceToggle()) 171 if (infobar_delegate_->ShouldShowPersistenceToggle())
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 navigation_handle->IsSameDocument()) { 260 navigation_handle->IsSameDocument()) {
262 return; 261 return;
263 } 262 }
264 263
265 DismissDialog(); 264 DismissDialog();
266 } 265 }
267 266
268 void PermissionDialogDelegate::WebContentsDestroyed() { 267 void PermissionDialogDelegate::WebContentsDestroyed() {
269 DismissDialog(); 268 DismissDialog();
270 } 269 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698