Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 292323007: Pepper: FileDownloader cleanup. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: FileDownloader cleanup. Now that StreamAsFile() has moved out of the trusted plugin, we can remove the support in FileDownloader for downloading to a file and providing file information as output. This makes FileDownloader quite a bit smaller and easier to read. BUG=239656 R=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272593

Patch Set 1 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -264 lines) Patch
M ppapi/native_client/src/trusted/plugin/file_downloader.h View 10 chunks +2 lines, -58 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/file_downloader.cc View 9 chunks +20 lines, -206 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
teravest
6 years, 7 months ago (2014-05-23 20:52:53 UTC) #1
bbudge
Hard work pays off. LGTM
6 years, 7 months ago (2014-05-23 20:59:49 UTC) #2
teravest
6 years, 7 months ago (2014-05-23 21:24:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r272593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698