Remove uses of IterableMixinWorkaround outside of VM and dart2js lists.

sdk/lib/collection/iterable.dart

Index: sdk/lib/collection/iterable.dart
diff --git a/sdk/lib/collection/iterable.dart b/sdk/lib/collection/iterable.dart
index 0e935377c4c0e585708afc8cbf5c37841fcb25eb..b6e52f4669e931320a443c262cd2208ca9668770 100644
--- a/sdk/lib/collection/iterable.dart
+++ b/sdk/lib/collection/iterable.dart
@@ -408,20 +408,27 @@ abstract class IterableBase<E> implements Iterable<E> {
   String toString() => _iterableToString(this);
 }
 
-String _iterableToString(Iterable iterable) {
-  if (_toStringVisiting.contains(iterable)) return "(...)";
+String _setToString(Set set) => _collectionToString(set, "{" , "}");

[floitsch, 2014/05/23 10:24:55]

This is not the same as `IterableMixinWorkaround.toStringIterable(this, '{',
'}');`

The IterableMixinWorkaround.toStringIterable was not shortening.

[Lasse Reichstein Nielsen, 2014/05/23 11:46:48]

I know, and I think it should be shortened if it is too long.
I'd do the same for List.

[floitsch, 2014/05/23 11:53:57]

That's a breaking change. I can easily imagine doing a print(list) instead of
going through JSON.encode when I know that the list only contains numbers.

Similarly, users may use the output of sets.

+
+String _iterableToString(Iterable iterable) =>
+    _collectionToString(iterable, "(", ")");
+
+String _collectionToString(Iterable iterable, String before, String after) {
+  if (_toStringVisiting.contains(iterable)) return "$before...$after";
   _toStringVisiting.add(iterable);
   List parts = [];
   try {
-    _iterablePartsToStrings(iterable, parts);
+    _collectionPartsToStrings(iterable, parts);
   } finally {
     _toStringVisiting.remove(iterable);
   }
-  return (new StringBuffer("(")..writeAll(parts, ", ")..write(")")).toString();
+  return (new StringBuffer(before)
+              ..writeAll(parts, ", ")
+              ..write(after)).toString();
 }
 
 /** Convert elments of [iterable] to strings and store them in [parts]. */
-void _iterablePartsToStrings(Iterable iterable, List parts) {
+void _collectionPartsToStrings(Iterable iterable, List parts) {
   /// Try to stay below this many characters.
   const int LENGTH_LIMIT = 80;
   /// Always at least this many elements at the start.
@@ -435,14 +442,15 @@ void _iterablePartsToStrings(Iterable iterable, List parts) {
   // number.
   const int OVERHEAD = 2;
   const int ELLIPSIS_SIZE = 3;  // "...".length.
-
   int length = 0;
   int count = 0;
   Iterator it = iterable.iterator;
   // Initial run of elements, at least HEAD_COUNT, and then continue until
   // passing at most LENGTH_LIMIT characters.
   while (length < LENGTH_LIMIT || count < HEAD_COUNT) {
-    if (!it.moveNext()) return;
+    if (!it.moveNext()) {
+      return;
+    }
     String next = "${it.current}";
     parts.add(next);
     length += next.length + OVERHEAD;
@@ -516,7 +524,8 @@ void _iterablePartsToStrings(Iterable iterable, List parts) {
   // HEAD_COUNT elements in the initial run, drop some to make room for
   // the last two.
   while (length > LENGTH_LIMIT && parts.length > HEAD_COUNT) {
-    length -= parts.removeLast().length + OVERHEAD;
+    String lastPart = parts.removeLast();
+    length -= lastPart.length + OVERHEAD;
     if (elision == null) {
       elision = "...";
       length += ELLIPSIS_SIZE + OVERHEAD;