Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 292323002: Unmangles ifdefs in ViewEventTestBase (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Unmangles ifdefs in ViewEventTestBase BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M chrome/test/base/view_event_test_base.cc View 3 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
6 years, 7 months ago (2014-05-22 04:05:50 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-22 04:48:09 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-22 14:01:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/292323002/1
6 years, 7 months ago (2014-05-22 14:02:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 14:54:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 14:57:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9761)
6 years, 7 months ago (2014-05-22 14:57:01 UTC) #7
sky
6 years, 7 months ago (2014-05-22 15:35:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r272189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698